From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:53754) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TJWeu-00046F-Gz for qemu-devel@nongnu.org; Wed, 03 Oct 2012 17:39:14 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TJWet-0000b0-Ns for qemu-devel@nongnu.org; Wed, 03 Oct 2012 17:39:12 -0400 Received: from mx1.redhat.com ([209.132.183.28]:20052) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TJWet-0000a3-FW for qemu-devel@nongnu.org; Wed, 03 Oct 2012 17:39:11 -0400 Date: Wed, 3 Oct 2012 18:40:01 -0300 From: Luiz Capitulino Message-ID: <20121003184001.219ab404@doriath.home> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: [Qemu-devel] [PATCH v2] qemu-ga: ga_open_pidfile(): add new line to pidfile List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: mdroth@linux.vnet.ibm.com Cc: blauwirbel@gmail.com, qemu-devel FHS requires that pid files should end with a new line. Also change to snprintf() while there. Signed-off-by: Luiz Capitulino --- o v2 - use snprintf() - re-word changelog qemu-ga.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/qemu-ga.c b/qemu-ga.c index b747470..e4026f8 100644 --- a/qemu-ga.c +++ b/qemu-ga.c @@ -255,7 +255,7 @@ static bool ga_open_pidfile(const char *pidfile) g_critical("Failed to truncate pid file"); goto fail; } - sprintf(pidstr, "%d", getpid()); + snprintf(pidstr, sizeof(pidstr), "%d\n", getpid()); if (write(pidfd, pidstr, strlen(pidstr)) != strlen(pidstr)) { g_critical("Failed to write pid file"); goto fail; -- 1.7.12.315.g682ce8b