From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:50325) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TJitV-000312-84 for qemu-devel@nongnu.org; Thu, 04 Oct 2012 06:43:09 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TJitU-00011i-4q for qemu-devel@nongnu.org; Thu, 04 Oct 2012 06:43:05 -0400 Received: from mail-ee0-f45.google.com ([74.125.83.45]:58470) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TJitT-00011a-Tc for qemu-devel@nongnu.org; Thu, 04 Oct 2012 06:43:04 -0400 Received: by mail-ee0-f45.google.com with SMTP id b47so274784eek.4 for ; Thu, 04 Oct 2012 03:43:02 -0700 (PDT) Date: Thu, 4 Oct 2012 12:42:57 +0200 From: "Edgar E. Iglesias" Message-ID: <20121004104257.GA21815@edde.se.axis.com> References: <1349346964-4151-1-git-send-email-avi@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1349346964-4151-1-git-send-email-avi@redhat.com> Subject: Re: [Qemu-devel] [PATCH v2] Make target_phys_addr_t 64 bits unconditionally List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Avi Kivity Cc: Jia Liu , qemu-devel@nongnu.org, Blue Swirl , Max Filippov , Michael Walle , Paul Brook , Anthony Liguori , Aurelien Jarno On Thu, Oct 04, 2012 at 12:36:04PM +0200, Avi Kivity wrote: > The hassle and compile time overhead of maintaining both 32-bit and 64-bit > capable source isn't worth the tiny performance advantage which is seen on > a minority of configurations. Switch to compiling libhw only once, with > target_phys_addr_t unconditionally typedefed to uint64_t. > > Signed-off-by: Avi Kivity > --- > > v2: no changes, but copied the maintainers of architectures that will > see their target_phys_addr_t changed as a result. Please view and/or > test. > Hi, I ran some quick tests on CRIS and MicroBlaze guests. Didn't see anything going wrong. Cheers, Edgar