From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:54717) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TJlCl-0004Gm-AZ for qemu-devel@nongnu.org; Thu, 04 Oct 2012 09:11:15 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TJlCk-0003IK-9r for qemu-devel@nongnu.org; Thu, 04 Oct 2012 09:11:07 -0400 Received: from mx1.redhat.com ([209.132.183.28]:27403) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TJlCk-0003IE-1i for qemu-devel@nongnu.org; Thu, 04 Oct 2012 09:11:06 -0400 Date: Thu, 4 Oct 2012 15:10:53 +0200 From: Igor Mammedov Message-ID: <20121004151053.1b3f67f6@nial.usersys.redhat.com> In-Reply-To: <506D87B9.7030803@suse.de> References: <1349192235-31895-8-git-send-email-imammedo@redhat.com> <20121002203845.GB4362@otherpad.lan.raisama.net> <20121003150339.GS15784@otherpad.lan.raisama.net> <506C57CE.9060002@redhat.com> <20121003182411.7075c0ef@nial.usersys.redhat.com> <20121003165434.GT15784@otherpad.lan.raisama.net> <20121004085322.599a19ab@nial.usersys.redhat.com> <20121004124341.GU15784@otherpad.lan.raisama.net> <506D87B9.7030803@suse.de> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH 07/23] target-i386: convert cpuid features into properties List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Andreas =?ISO-8859-1?B?RuRyYmVy?= Cc: aliguori@us.ibm.com, hpa@linux.intel.com, Eduardo Habkost , gleb@redhat.com, jan.kiszka@siemens.com, Don@cloudswitch.com, mtosatti@redhat.com, qemu-devel@nongnu.org, mdroth@linux.vnet.ibm.com, blauwirbel@gmail.com, avi@redhat.com, Paolo Bonzini , akong@redhat.com, lersek@redhat.com, stefanha@linux.vnet.ibm.com On Thu, 04 Oct 2012 14:57:29 +0200 Andreas F=E4rber wrote: > Am 04.10.2012 14:43, schrieb Eduardo Habkost: > > On Thu, Oct 04, 2012 at 08:53:22AM +0200, Igor Mammedov wrote: > >> For x86 CPU classes we were going dynamically generate CPU classes and > >> store pointer to appropriate cpudef from builtin_x86_defs in class fie= ld > >> for each CPU class and then init default feature words values from this > >> field int x86_cpu_initfn(). > >> > >> However with qdev_prop_set_globals() in device_initfn() that is called > >> before x86_cpu_initfn() it won't work because defaults in > >> x86_cpu_initfn() will overwrite whatever was set by > >> qdev_prop_set_globals(). > >=20 > > We can set the default values on class_init, instead. The class_init > > function for each CPU model can get the x86_def_t struct as the data > > pointer. >=20 > Let's avoid going backwards here, the plan was to have imperative > initfns, so x86_def_t would go away, no? >=20 > I'm catching up my mail on multiple fronts and will continue review, > IIUC Blue already applied the CPU feature deduplification series so > according to your roadmap this series is next. >=20 I guess no, it's now cpu-as-device that should be next on a queue, since I'm rewriting this series to use static properties instead so CPU must be a device. Though work would be easier if static props we written&applied on top of this, it's not like we need working for CPU qdev_prop_set_globals() after t= his series.