From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:56931)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <flukshun@gmail.com>) id 1TJp5w-0004ul-M1
	for qemu-devel@nongnu.org; Thu, 04 Oct 2012 13:20:26 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <flukshun@gmail.com>) id 1TJp5m-00036N-GB
	for qemu-devel@nongnu.org; Thu, 04 Oct 2012 13:20:19 -0400
Received: from mail-ob0-f173.google.com ([209.85.214.173]:36562)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <flukshun@gmail.com>) id 1TJndr-0005yX-CN
	for qemu-devel@nongnu.org; Thu, 04 Oct 2012 11:47:15 -0400
Received: by mail-ob0-f173.google.com with SMTP id wc18so577738obb.4
	for <qemu-devel@nongnu.org>; Thu, 04 Oct 2012 08:47:14 -0700 (PDT)
Sender: fluxion <flukshun@gmail.com>
Date: Thu, 4 Oct 2012 10:47:06 -0500
From: Michael Roth <mdroth@linux.vnet.ibm.com>
Message-ID: <20121004154706.GF16157@illuin>
References: <1349300158-19113-1-git-send-email-lcapitulino@redhat.com>
	<1349300158-19113-3-git-send-email-lcapitulino@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1349300158-19113-3-git-send-email-lcapitulino@redhat.com>
Subject: Re: [Qemu-devel] [PATCH 2/2] qemu-ga: use state dir from
	CONFIG_QEMU_LOCALSTATEDIR
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Luiz Capitulino <lcapitulino@redhat.com>
Cc: pbonzini@redhat.com, qemu-devel@nongnu.org

On Wed, Oct 03, 2012 at 06:35:58PM -0300, Luiz Capitulino wrote:
> Has the side effect of changing the default directory used to
> save the freeze status file from /tmp to ${prefix}/var/run.
> 
> This is a beneficial change for two reasons:
> 
>   1. FHS states that programs must not assume that files in /tmp will
>      still exist between invocations of the program. This defeats
> 	 the purpose of the freeze status file
> 
>   2. FHS dictates that /var/run must be cleaned on boot, this
>      ensures that a stale freeze status file will be removed on boot
> 
> Signed-off-by: Luiz Capitulino <lcapitulino@redhat.com>
> ---
>  qemu-ga.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/qemu-ga.c b/qemu-ga.c
> index b747470..daeaea5 100644
> --- a/qemu-ga.c
> +++ b/qemu-ga.c
> @@ -40,8 +40,8 @@
>  #else
>  #define QGA_VIRTIO_PATH_DEFAULT "\\\\.\\Global\\org.qemu.guest_agent.0"
>  #endif
> -#define QGA_PIDFILE_DEFAULT "/var/run/qemu-ga.pid"
> -#define QGA_STATEDIR_DEFAULT "/tmp"
> +#define QGA_STATEDIR_DEFAULT CONFIG_QEMU_LOCALSTATEDIR "/run"
> +#define QGA_PIDFILE_DEFAULT QGA_STATEDIR_DEFAULT "/qemu-ga.pid"

Just to confirm, in configure we have:

echo "qemu_localstatedir=$local_statedir" >> $config_host_mak

Is there some magic that generates a CONFIG_QEMU_LOCALSTATEDIR with the
same value? If so:

Reviewed-by: Michael Roth <mdroth@linux.vnet.ibm.com>

>  #define QGA_SENTINEL_BYTE 0xFF
> 
>  struct GAState {
> -- 
> 1.7.12.315.g682ce8b
>