From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:56577)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <imammedo@redhat.com>) id 1TJm3E-0003n2-Mo
	for qemu-devel@nongnu.org; Thu, 04 Oct 2012 10:05:27 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <imammedo@redhat.com>) id 1TJm37-0000n4-QM
	for qemu-devel@nongnu.org; Thu, 04 Oct 2012 10:05:20 -0400
Received: from mx1.redhat.com ([209.132.183.28]:13553)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <imammedo@redhat.com>) id 1TJm37-0000li-II
	for qemu-devel@nongnu.org; Thu, 04 Oct 2012 10:05:13 -0400
Date: Thu, 4 Oct 2012 16:05:09 +0200
From: Igor Mammedov <imammedo@redhat.com>
Message-ID: <20121004160509.07cbb503@nial.usersys.redhat.com>
In-Reply-To: <20121004131448.GC4362@otherpad.lan.raisama.net>
References: <1349270954-4657-1-git-send-email-ehabkost@redhat.com>
	<1349270954-4657-6-git-send-email-ehabkost@redhat.com>
	<20121004140057.60398752@nial.usersys.redhat.com>
	<20121004131448.GC4362@otherpad.lan.raisama.net>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [RFC 05/18] cpus.h: include qemu-stdio.h
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Eduardo Habkost <ehabkost@redhat.com>
Cc: Paolo Bonzini <pbonzini@redhat.com>, qemu-devel@nongnu.org, Gleb Natapov <gleb@redhat.com>, Andreas =?ISO-8859-1?B?RuRyYmVy?= <afaerber@suse.de>

On Thu, 4 Oct 2012 10:14:48 -0300
Eduardo Habkost <ehabkost@redhat.com> wrote:

> On Thu, Oct 04, 2012 at 02:00:57PM +0200, Igor Mammedov wrote:
> > On Wed,  3 Oct 2012 10:29:01 -0300
> > Eduardo Habkost <ehabkost@redhat.com> wrote:
> > 
> > > Needed for the definition of fprint_function.
> > > 
> > > This is not necessary right now, but it will be necessary if code that
> > > doesn't include cpu-common.h includes cpus.h.
> > Could be it cut to a separate standard hearders, and include only that on
> > which it depends?
> 
> Are you talking about cpus.h, or qemu-stdio.h?
Ah, never mind, I see it is included for fprint_function().

> 
> qemu-stdio.h is a new header, and is very small. I don't see how we
> could split it further.
> 
> cpus.h is tiny, too, I don't see why we would split it.
> 
> > 
> > > 
> > > Signed-off-by: Eduardo Habkost <ehabkost@redhat.com>
> > > ---
> > >  cpus.h | 2 ++
> > >  1 file changed, 2 insertions(+)
> > > 
> > > diff --git a/cpus.h b/cpus.h
> > > index 81bd817..b7c3708 100644
> > > --- a/cpus.h
> > > +++ b/cpus.h
> > > @@ -1,6 +1,8 @@
> > >  #ifndef QEMU_CPUS_H
> > >  #define QEMU_CPUS_H
> > >  
> > > +#include "qemu-stdio.h"
> > > +
> > >  /* cpus.c */
> > >  void qemu_init_cpu_loop(void);
> > >  void resume_all_vcpus(void);
> > 
> > 
>