From: Stefan Hajnoczi <stefanha@gmail.com>
To: Stefan Weil <sw@weilnetz.de>
Cc: qemu-trivial@nongnu.org, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [Qemu-trivial] [PATCH] qemu-sockets: Fix compiler warning (regression for MinGW)
Date: Fri, 5 Oct 2012 14:49:08 +0200 [thread overview]
Message-ID: <20121005124908.GE10951@stefanha-thinkpad.redhat.com> (raw)
In-Reply-To: <1348852059-8678-1-git-send-email-sw@weilnetz.de>
On Fri, Sep 28, 2012 at 07:07:39PM +0200, Stefan Weil wrote:
> setsockopt needs a type cast for MinGW. That type cast is missing in
> a recent commit which results in a compiler warning.
>
> Like for other socket related functions which have the same problem,
> we add a 'qemu_setsockopt' macro which provides that type cast where
> needed and use the new macro to avoid the warning.
>
> A 'qemu_getsockopt' is also added and can be used for future
> modifications.
>
> Signed-off-by: Stefan Weil <sw@weilnetz.de>
> ---
> qemu-common.h | 10 +++++++++-
> qemu-sockets.c | 2 +-
> 2 files changed, 10 insertions(+), 2 deletions(-)
Thanks, applied to the trivial patches tree:
https://github.com/stefanha/qemu/commits/trivial-patches
Stefan
prev parent reply other threads:[~2012-10-05 12:49 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-28 17:07 [Qemu-devel] [PATCH] qemu-sockets: Fix compiler warning (regression for MinGW) Stefan Weil
2012-10-05 12:49 ` Stefan Hajnoczi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121005124908.GE10951@stefanha-thinkpad.redhat.com \
--to=stefanha@gmail.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
--cc=sw@weilnetz.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).