From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:59526) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TK8H9-0008Mm-H6 for qemu-devel@nongnu.org; Fri, 05 Oct 2012 09:49:12 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TK8H1-0000vw-EE for qemu-devel@nongnu.org; Fri, 05 Oct 2012 09:49:11 -0400 Date: Fri, 5 Oct 2012 15:48:58 +0200 From: Stefan Hajnoczi Message-ID: <20121005134858.GH10951@stefanha-thinkpad.redhat.com> References: <1349298662-16666-1-git-send-email-sw@weilnetz.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1349298662-16666-1-git-send-email-sw@weilnetz.de> Subject: Re: [Qemu-devel] [Qemu-trivial] [PATCH] qemu-barrier: Fix compiler version check for future gcc versions List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Stefan Weil Cc: qemu-trivial@nongnu.org, "Michael S. Tsirkin" , qemu-devel@nongnu.org, qemu-stable@nongnu.org On Wed, Oct 03, 2012 at 11:11:02PM +0200, Stefan Weil wrote: > The current check will give a wrong result for gcc-5.x with x < 4. > Using QEMU_GNUC_PREREQ is simpler and fixes that issue. > > Signed-off-by: Stefan Weil > --- > > With current gcc versions (gcc-4.x) there is no problem. > Nevertheless, I suggest to fix this in stable versions, too. > > Regards > > Stefan Weil > > qemu-barrier.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Thanks, applied to the trivial patches tree: https://github.com/stefanha/qemu/commits/trivial-patches Stefan