From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:53820) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TKBhv-0005Zn-B7 for qemu-devel@nongnu.org; Fri, 05 Oct 2012 13:29:04 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TKBhu-0005aO-6R for qemu-devel@nongnu.org; Fri, 05 Oct 2012 13:29:03 -0400 Received: from mx1.redhat.com ([209.132.183.28]:8898) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TKBht-0005aI-UG for qemu-devel@nongnu.org; Fri, 05 Oct 2012 13:29:02 -0400 Date: Fri, 5 Oct 2012 14:28:16 -0300 From: Marcelo Tosatti Message-ID: <20121005172816.GB11796@amt.cnet> References: <20121005171338.092840368@amt.cnet> <20121005171442.345782891@amt.cnet> <506F178E.6070406@siemens.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <506F178E.6070406@siemens.com> Subject: Re: [Qemu-devel] [patch 3/7] Use machine options to emulate -no-kvm-pit List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Jan Kiszka Cc: Anthony Liguori , qemu-devel@nongnu.org, Gerd Hoffmann On Fri, Oct 05, 2012 at 07:23:26PM +0200, Jan Kiszka wrote: > On 2012-10-05 19:13, Marcelo Tosatti wrote: > > From: Jan Kiszka > > > > Releases of qemu-kvm will be interrupted at qemu 1.3.0. > > Users should switch to plain qemu releases. > > To avoid breaking scenarios which are setup with command line > > options specific to qemu-kvm, port these switches from qemu-kvm > > to qemu.git. > > > > Port -no-kvm-pit option. > > > > Signed-off-by: Marcelo Tosatti > > > > Index: qemu-compat-kvm/vl.c > > =================================================================== > > --- qemu-compat-kvm.orig/vl.c > > +++ qemu-compat-kvm/vl.c > > @@ -3066,6 +3066,11 @@ int main(int argc, char **argv, char **e > > machine = machine_parse(optarg); > > } > > break; > > + case QEMU_OPTION_no_kvm_pit: { > > + fprintf(stderr, "Warning: KVM PIT can no longer be disabled " > > + "separately.\n"); > > + break; > > + } > > case QEMU_OPTION_usb: > > usb_enabled = 1; > > break; > > Index: qemu-compat-kvm/qemu-options.hx > > =================================================================== > > --- qemu-compat-kvm.orig/qemu-options.hx > > +++ qemu-compat-kvm/qemu-options.hx > > @@ -2838,6 +2838,9 @@ STEXI > > Enable FIPS 140-2 compliance mode. > > ETEXI > > > > +HXCOMM Deprecated (ignored) > > +DEF("no-kvm-pit", HAS_ARG, QEMU_OPTION_no_kvm_pit, "", QEMU_ARCH_I386) > > + > > HXCOMM Deprecated by -machine kernel_irqchip=on|off property > > DEF("no-kvm-irqchip", HAS_ARG, QEMU_OPTION_no_kvm_irqchip, "", QEMU_ARCH_I386) > > > > > > > > This doesn't emulate anything. It just adds a warning that some long > disabled option was used. > > Jan It emulates the command line switch. In my mind, "printing a warning" can be considered "emulating a command from qemu-kvm". If you prefer something else, please let me know the best wording.