From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:58261) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TKSZQ-00048K-L6 for qemu-devel@nongnu.org; Sat, 06 Oct 2012 07:29:25 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TKSZP-0001v4-0F for qemu-devel@nongnu.org; Sat, 06 Oct 2012 07:29:24 -0400 Received: from smtp4.mundo-r.com ([212.51.32.151]:14949) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TKSZO-0001ur-PS for qemu-devel@nongnu.org; Sat, 06 Oct 2012 07:29:22 -0400 Date: Sat, 6 Oct 2012 13:29:20 +0200 From: Alberto Garcia Message-ID: <20121006112920.GA13587@igalia.com> References: <20120831141231.GA18777@igalia.com> <5040E1A7.4010401@suse.de> <20121005132036.GA29555@igalia.com> <506EEE79.10608@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Subject: Re: [Qemu-devel] Ping [PATCH 0/2] Add TPCI200 and IP-Octal 232 IndustryPack emulation List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Blue Swirl Cc: Anthony Liguori , qemu-devel@nongnu.org, Avi Kivity , Paolo Bonzini , Andreas =?iso-8859-1?Q?F=E4rber?= , Paul Brook On Fri, Oct 05, 2012 at 04:24:08PM +0000, Blue Swirl wrote: > Endianness looks buggy, there's no way to turn off big endian mode I double checked the documentation and I think you're right, I can update the patch. Thanks for pointing it out. > DEVICE_NATIVE_ENDIAN should probably be DEVICE_LITTLE_ENDIAN. Where? In BAR0? > Indentation of braces in switch cases looks strange. I tried to follow the CODING_STYLE file, but I might have got it wrong, I can change that. > Pointers to HW documentation and description how to test (or qtests) > would be nice. The documentation is available online: http://www.tews.com/Products/ArticleGroup/TPCI/TPCI200.html http://www.mvme.com/manuals/IP-OCTAL-232_UM.pdf http://www.alldatasheet.com/datasheet-pdf/pdf/19123/PHILIPS/SCC2698B.html I'm not familiar with qtests, should I take a look at it? In my blog post (see previous e-mail) there's a brief explanation on how to test it. I can provide with a compiled Linux kernel with the necessary drivers for the guest system if it helps. A quick way to test it is to redirect one of the IP-Octal serial ports to a pty in the host and open minicom in both sides. > I'd suppose addressing devices in the bus could be implemented > more efficiently with better use of memory API, now some of it is > reimplemented. Maybe Avi can propose something? I'm open to suggestions. And answering Andreas, yes, the device could be renamed as 'ipoctal232' :) Thanks, Berto