qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: David Gibson <david@gibson.dropbear.id.au>
To: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Cc: Erlon Cruz <erlon.cruz@br.flextronics.com>,
	Alexander Graf <agraf@suse.de>,
	Anthony Liguori <anthony@codemonkey.ws>,
	qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] Enablig DLPAR capacity on QEMU pSeries
Date: Sun, 7 Oct 2012 00:54:49 +1000	[thread overview]
Message-ID: <20121006145449.GZ29302@truffula.fritz.box> (raw)
In-Reply-To: <1349470153.4260.74.camel@pasglop>

On Sat, Oct 06, 2012 at 06:49:13AM +1000, Benjamin Herrenschmidt wrote:
> On Fri, 2012-10-05 at 09:42 -0500, Anthony Liguori wrote:
> > >  - We have a problem with PCI. Currently, the content of the PCI
> > > bus(ses) is discovered by SLOF running inside the guest. Not by qemu.
> > > It's SLOF that assigns the BARs and create the device-tree nodes for the
> > > various PCI devices. However, with hotplug, the guest expects to get
> > > fully populated DT nodes for hotplugged PCI devices and fully assigned
> > > BARS. Under pHyp that works because under the hood, RTAS contains an OFW
> > > implementation which does all the assignment before passing the stuff to
> > > the OS, but under qemu, RTAS is actually in qemu. This means we'll
> > > probably have to move back the PCI device node creation and resource
> > > assignment to qemu (like it was in the very early versions of the spapr
> > > support).
> > 
> > I know you and I have discussed this in the past, but not on the list
> > and now I don't recall the reasoning.
> > 
> > Why not add a proper RTAS and do this work there?
> 
> Because it's a PITA ? We could ... but that means we'd have to write
> some kind of FW blob that is relocatable and capable of "live"
> relocating itself (the versions that would run within SLOF need to
> transfer control to one at a different address that runs within the OS
> context since the OS decides where RTAS lives).
> 
> It would have to know the device-tree to handle DLPAR (thus get "synced"
> by OF on any DT change until OF is killed by the OF).
> 
> Generally writing yet another blob means yet another piece of SW to
> write from scratch, maintain, package, deal with dependencies, debug,
> etc...
> 
> It is an option though, just not a nice one. And a fairly time consuming
> one too.

I also don't see how it helps in this situation.  The hotplug will
still be initiated by qemu, so we'd have to work out how qemu
communicates the info to RTAS, and how RTAS communicates it to the
kernel, doubling the work.

-- 
David Gibson			| I'll have my music baroque, and my code
david AT gibson.dropbear.id.au	| minimalist, thank you.  NOT _the_ _other_
				| _way_ _around_!
http://www.ozlabs.org/~dgibson

  reply	other threads:[~2012-10-06 15:37 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-09-12 14:54 [Qemu-devel] Enablig DLPAR capacity on QEMU pSeries Erlon Cruz
2012-09-12 15:53 ` Alexander Graf
2012-09-12 20:56   ` Erlon Cruz
2012-09-12 21:42     ` Alexander Graf
2012-09-12 21:48   ` Benjamin Herrenschmidt
2012-09-13 15:15     ` Erlon Cruz
2012-09-13 21:45       ` Benjamin Herrenschmidt
2012-10-05 14:08         ` Erlon Cruz
2012-10-05 14:42     ` Anthony Liguori
2012-10-05 15:26       ` Erlon Cruz
2012-10-05 20:56         ` Benjamin Herrenschmidt
2012-10-05 20:49       ` Benjamin Herrenschmidt
2012-10-06 14:54         ` David Gibson [this message]
2012-10-06 19:39           ` Benjamin Herrenschmidt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20121006145449.GZ29302@truffula.fritz.box \
    --to=david@gibson.dropbear.id.au \
    --cc=agraf@suse.de \
    --cc=anthony@codemonkey.ws \
    --cc=benh@kernel.crashing.org \
    --cc=erlon.cruz@br.flextronics.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).