From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:45853) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TKnHA-0002s6-BD for qemu-devel@nongnu.org; Sun, 07 Oct 2012 05:35:57 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TKnH9-0002xn-3d for qemu-devel@nongnu.org; Sun, 07 Oct 2012 05:35:56 -0400 Received: from mx1.redhat.com ([209.132.183.28]:49788) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TKnH8-0002xX-MT for qemu-devel@nongnu.org; Sun, 07 Oct 2012 05:35:54 -0400 Received: from int-mx01.intmail.prod.int.phx2.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q979ZqLS010979 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Sun, 7 Oct 2012 05:35:52 -0400 Date: Sun, 7 Oct 2012 11:35:31 +0200 From: Alon Levy Message-ID: <20121007093531.GA6184@garlic.redhat.com> References: <1346916100-12958-1-git-send-email-kraxel@redhat.com> <1346916100-12958-11-git-send-email-kraxel@redhat.com> <50657321.2030100@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <50657321.2030100@redhat.com> Subject: Re: [Qemu-devel] [PATCH 10/14] qxl: add QXL_IO_MONITORS_CONFIG_ASYNC List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini Cc: Gerd Hoffmann , qemu-devel@nongnu.org On Fri, Sep 28, 2012 at 11:51:29AM +0200, Paolo Bonzini wrote: > Il 06/09/2012 09:21, Gerd Hoffmann ha scritto: > > +#ifndef CONFIG_QXL_IO_MONITORS_CONFIG_ASYNC > > +/* spice-protocol is too old, add missing definitions */ > > +#define QXL_IO_MONITORS_CONFIG_ASYNC (QXL_IO_FLUSH_RELEASE + 1) > > +#endif > > + > > I don't see the need for this, why can't you just bump the minimum > required version of spice-protocol? Or import the headers (and only the > headers) in QEMU? Sorry for the late reply. Gerd wanted to bump the protocol version once after we do a release of spice-protocol and spice-server, which has happened now so this patch should be only an intermediate state that will be removed when spice-protocol is bumped like you suggest. Importing spice-protocol headers is ugly, I would rather not maintain them twice (I do plan on doing it in the linux kernel but there I see no other choice). > > Also, please consider adding the library version in the spice-protocol > header files, so that you do not need > CONFIG_QXL_IO_MONITORS_CONFIG_ASYNC at all. spice-protocol is a separate repository from spice library. Adding the spice-protocol dependency as a submodule would have been my preferred solution but it has been shot down by Anthony. > > Paolo >