From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:48313)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <agarcia@igalia.com>) id 1TL8J3-0000VO-VZ
	for qemu-devel@nongnu.org; Mon, 08 Oct 2012 04:03:23 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <agarcia@igalia.com>) id 1TL8Ix-0001eo-Ib
	for qemu-devel@nongnu.org; Mon, 08 Oct 2012 04:03:17 -0400
Received: from smtp4.mundo-r.com ([212.51.32.151]:52439)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <agarcia@igalia.com>) id 1TL8Ix-0001c1-Bp
	for qemu-devel@nongnu.org; Mon, 08 Oct 2012 04:03:11 -0400
Date: Mon, 8 Oct 2012 10:02:25 +0200
From: Alberto Garcia <agarcia@igalia.com>
Message-ID: <20121008080225.GA32199@igalia.com>
References: <cover.1345730024.git.agarcia@igalia.com>
	<20120831141231.GA18777@igalia.com> <5040E1A7.4010401@suse.de>
	<20121005132036.GA29555@igalia.com> <506EEE79.10608@redhat.com>
	<CAAu8pHvx+X8QH3mkdwGffKBHyo8teM8wN9wH8Cd4SUUHWt-N1A@mail.gmail.com>
	<507155E1.6090907@redhat.com> <5071571B.8020505@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <5071571B.8020505@redhat.com>
Subject: Re: [Qemu-devel] Ping [PATCH 0/2] Add TPCI200 and IP-Octal 232
 IndustryPack emulation
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Avi Kivity <avi@redhat.com>
Cc: Anthony Liguori <aliguori@us.ibm.com>, qemu-devel@nongnu.org, Blue Swirl <blauwirbel@gmail.com>, Paul Brook <paul@codesourcery.com>, Paolo Bonzini <pbonzini@redhat.com>, Andreas =?iso-8859-1?Q?F=E4rber?= <afaerber@suse.de>

On Sun, Oct 07, 2012 at 12:19:07PM +0200, Avi Kivity wrote:

> > So you could easily have
> > 
> >  struct IPackDevice {
> >      DeviceState qdev;
> >      int32_t slot;
> >      /* IRQ objects for the IndustryPack INT0# and INT1# */
> >      qemu_irq *irq;
> >      MemoryRegion io_space;
> >      MemoryRegion id_space;
> >      MemoryRegion int_space;
> >      MemoryRegion mem8_space;  /* for las3 */
> >      MemoryRegion mem16_space; /* for las2 */
> >  };
> > 
> Note: you can easily verify that the mapping is correct with 'info
> mtree'.  You should see something like:

I got the idea, it sounds like a better solution, I'll try to rework
the patch with all the proposed changes and post it again, thanks!

Berto