From: Amit Shah <amit.shah@redhat.com>
To: Marcelo Tosatti <mtosatti@redhat.com>
Cc: "kvm list" <kvm@vger.kernel.org>,
"Raghavendra K T" <raghavendra.kt@linux.vnet.ibm.com>,
"qemu list" <qemu-devel@nongnu.org>,
"Eric B Munson" <emunson@mgebm.net>,
"Paolo Bonzini" <pbonzini@redhat.com>,
"Laszlo Ersek" <lersek@redhat.com>,
"Andreas Färber" <afaerber@suse.de>
Subject: Re: [Qemu-devel] [PATCH 1/1] kvmclock: fix guest stop notification
Date: Mon, 8 Oct 2012 16:10:22 +0530 [thread overview]
Message-ID: <20121008104022.GB25290@amit.redhat.com> (raw)
In-Reply-To: <20120930230516.GA3923@amt.cnet>
On (Sun) 30 Sep 2012 [20:05:16], Marcelo Tosatti wrote:
> On Thu, Sep 20, 2012 at 09:46:41AM -0300, Marcelo Tosatti wrote:
> > On Thu, Sep 20, 2012 at 01:55:20PM +0530, Amit Shah wrote:
> > > Commit f349c12c0434e29c79ecde89029320c4002f7253 added the guest stop
> > > notification, but it did it in a way that the stop notification would
> > > never reach the kernel. The kvm_vm_state_changed() function gets a
> > > value of 0 for the 'running' parameter when the VM is stopped, making
> > > all the code added previously dead code.
> > >
> > > This patch reworks the code so that it's called when 'running' is 0,
> > > which indicates the VM was stopped.
...
> NACK, guest should be notified when the VM is starting, not
> when stopping.
Ah, right.
Amit
next prev parent reply other threads:[~2012-10-08 10:40 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-20 8:25 [Qemu-devel] [PATCH 1/1] kvmclock: fix guest stop notification Amit Shah
2012-09-20 12:46 ` Marcelo Tosatti
2012-09-30 23:05 ` Marcelo Tosatti
2012-10-01 1:50 ` Amos Kong
2012-10-03 13:28 ` Marcelo Tosatti
2012-10-08 10:43 ` Amit Shah
2012-10-08 10:40 ` Amit Shah [this message]
2012-09-20 12:47 ` Marcelo Tosatti
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121008104022.GB25290@amit.redhat.com \
--to=amit.shah@redhat.com \
--cc=afaerber@suse.de \
--cc=emunson@mgebm.net \
--cc=kvm@vger.kernel.org \
--cc=lersek@redhat.com \
--cc=mtosatti@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=raghavendra.kt@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).