From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:35748)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <amit.shah@redhat.com>) id 1TLAlE-0004X6-FD
	for qemu-devel@nongnu.org; Mon, 08 Oct 2012 06:40:33 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <amit.shah@redhat.com>) id 1TLAlD-00048g-Fh
	for qemu-devel@nongnu.org; Mon, 08 Oct 2012 06:40:32 -0400
Received: from mx1.redhat.com ([209.132.183.28]:20666)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <amit.shah@redhat.com>) id 1TLAlD-00047B-7O
	for qemu-devel@nongnu.org; Mon, 08 Oct 2012 06:40:31 -0400
Date: Mon, 8 Oct 2012 16:10:22 +0530
From: Amit Shah <amit.shah@redhat.com>
Message-ID: <20121008104022.GB25290@amit.redhat.com>
References: <a7267230c907a452a2dbf96daae5332178044741.1348129517.git.amit.shah@redhat.com>
	<20120920124641.GA15092@amt.cnet> <20120930230516.GA3923@amt.cnet>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20120930230516.GA3923@amt.cnet>
Subject: Re: [Qemu-devel] [PATCH 1/1] kvmclock: fix guest stop notification
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Marcelo Tosatti <mtosatti@redhat.com>
Cc: kvm list <kvm@vger.kernel.org>, Raghavendra K T <raghavendra.kt@linux.vnet.ibm.com>, qemu list <qemu-devel@nongnu.org>, Eric B Munson <emunson@mgebm.net>, Paolo Bonzini <pbonzini@redhat.com>, Laszlo Ersek <lersek@redhat.com>, Andreas =?iso-8859-1?Q?F=E4rber?= <afaerber@suse.de>

On (Sun) 30 Sep 2012 [20:05:16], Marcelo Tosatti wrote:
> On Thu, Sep 20, 2012 at 09:46:41AM -0300, Marcelo Tosatti wrote:
> > On Thu, Sep 20, 2012 at 01:55:20PM +0530, Amit Shah wrote:
> > > Commit f349c12c0434e29c79ecde89029320c4002f7253 added the guest stop
> > > notification, but it did it in a way that the stop notification would
> > > never reach the kernel.  The kvm_vm_state_changed() function gets a
> > > value of 0 for the 'running' parameter when the VM is stopped, making
> > > all the code added previously dead code.
> > > 
> > > This patch reworks the code so that it's called when 'running' is 0,
> > > which indicates the VM was stopped.

...

> NACK, guest should be notified when the VM is starting, not
> when stopping.

Ah, right.

		Amit