From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:34409)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <aurelien@aurel32.net>) id 1TLH0D-0005pe-J2
	for qemu-devel@nongnu.org; Mon, 08 Oct 2012 13:20:26 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <aurelien@aurel32.net>) id 1TLH0C-00014T-8z
	for qemu-devel@nongnu.org; Mon, 08 Oct 2012 13:20:25 -0400
Received: from hall.aurel32.net ([88.191.126.93]:47768)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <aurelien@aurel32.net>) id 1TLH0C-00012u-23
	for qemu-devel@nongnu.org; Mon, 08 Oct 2012 13:20:24 -0400
Date: Mon, 8 Oct 2012 19:20:10 +0200
From: Aurelien Jarno <aurelien@aurel32.net>
Message-ID: <20121008172010.GG4055@ohm.aurel32.net>
References: <1349710923-30913-1-git-send-email-rth@twiddle.net>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-15
Content-Disposition: inline
In-Reply-To: <1349710923-30913-1-git-send-email-rth@twiddle.net>
Subject: Re: [Qemu-devel] [PATCH] target-sparc: Fix optimized %icc
	comparisons
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Richard Henderson <rth@twiddle.net>
Cc: Blue Swirl <blauwirbel@gmail.com>, qemu-devel@nongnu.org

On Mon, Oct 08, 2012 at 08:42:03AM -0700, Richard Henderson wrote:
> Signed-off-by: Richard Henderson <rth@twiddle.net>
> ---
>  target-sparc/translate.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> This should fix the boot problem that Aurelien saw.  It also showed
> up in some userland speed testing I'm trying to set up (cross gcc).
> 
> 

I confirm it fixes the issue I reported.

Tested-by: Aurelien Jarno <aurelien@aurel32.net>


> diff --git a/target-sparc/translate.c b/target-sparc/translate.c
> index 472eb51..71b9d65 100644
> --- a/target-sparc/translate.c
> +++ b/target-sparc/translate.c
> @@ -1120,6 +1120,7 @@ static void gen_compare(DisasCompare *cmp, bool xcc, unsigned int cond,
>                  cmp->c2 = tcg_temp_new();
>                  tcg_gen_ext32s_tl(cmp->c1, cpu_cc_src);
>                  tcg_gen_ext32s_tl(cmp->c2, cpu_cc_src2);
> +                break;
>              }
>  #endif
>              cmp->g1 = cmp->g2 = true;
> -- 
> 1.7.11.4
> 
> 

-- 
Aurelien Jarno                          GPG: 1024D/F1BCDB73
aurelien@aurel32.net                 http://www.aurel32.net