From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:44458)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <lcapitulino@redhat.com>) id 1TLZmu-0000my-92
	for qemu-devel@nongnu.org; Tue, 09 Oct 2012 09:23:57 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <lcapitulino@redhat.com>) id 1TLZml-0003lM-6h
	for qemu-devel@nongnu.org; Tue, 09 Oct 2012 09:23:56 -0400
Received: from mx1.redhat.com ([209.132.183.28]:58525)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <lcapitulino@redhat.com>) id 1TLZmk-0003kW-TG
	for qemu-devel@nongnu.org; Tue, 09 Oct 2012 09:23:47 -0400
Received: from int-mx10.intmail.prod.int.phx2.redhat.com
	(int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23])
	by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q99DNjgu020990
	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK)
	for <qemu-devel@nongnu.org>; Tue, 9 Oct 2012 09:23:45 -0400
Date: Tue, 9 Oct 2012 10:24:39 -0300
From: Luiz Capitulino <lcapitulino@redhat.com>
Message-ID: <20121009102439.15ff8fbe@doriath.home>
In-Reply-To: <20121008110212.GG20230@redhat.com>
References: <506F72C3.5080304@redhat.com> <20121008110212.GG20230@redhat.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] RFC: making QMP query-block more useful
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: "Daniel P. Berrange" <berrange@redhat.com>
Cc: Jeff Cody <jcody@redhat.com>, QEMU Developers <qemu-devel@nongnu.org>

On Mon, 8 Oct 2012 12:02:12 +0100
"Daniel P. Berrange" <berrange@redhat.com> wrote:

> On Fri, Oct 05, 2012 at 05:52:35PM -0600, Eric Blake wrote:
> > Right now, 'query-block' has no way to filter to a single device, but
> > conversely, for each device, it shows only the first backing file,
> > rather than the entire backing chain.  Jeff and I were lamenting this
> > fact on IRC while debugging his block-commit stuff.
> > 
> > Would it be worth enhancing the QMP to be:
> > 
> > ##
> > # @query-block:
> > #
> > # Get a list of BlockInfo for various virtual block devices.
> > #
> > # @devices: #optional If provided, limit the output to the given
> > #           device names (since 1.3)
> > #
> > # @recurse: #optional Provide recursive information on any backing
> > #           chains (since 1.3, default false)
> > #
> > # Returns: a list of @BlockInfo describing each virtual block device
> > #
> > # Since: 0.14.0
> > ##
> > { 'command': 'query-block',
> >   'arguments': { '*names': ['str'], 'recurse': 'bool' },
> >   'returns': ['BlockInfo'] }
> > 
> > as well as enhancing BlockDeviceInfo to be self-recursive, by adding
> > backing_chain as in:
> > 
> > # @backing_chain: #optional, only present if @backing_file is present
> > and 'query-block' requested recursion (since 1.3)
> > 
> > { 'type': 'BlockDeviceInfo',
> >   'data': { 'file': 'str', 'ro': 'bool', 'drv': 'str',
> >             '*backing_file': 'str', 'backing_file_depth': 'int',
> >             '*backing_chain' : 'BlockDeviceInfo',
> >             'encrypted': 'bool', 'encryption_key_missing': 'bool',
> >             'bps': 'int', 'bps_rd': 'int', 'bps_wr': 'int',
> >             'iops': 'int', 'iops_rd': 'int', 'iops_wr': 'int'} }
> > 
> > Or would such modifications require the creation of a new QMP command,
> > instead of altering 'query-block'?
> 
> I think I'd probably go for creating a new command myself. I agree that
> both the changes you describe would be useful for libvirt needs.

I vote for a new command too.