From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:53032) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TLZOb-0007ll-TA for qemu-devel@nongnu.org; Tue, 09 Oct 2012 08:58:53 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TLZOT-0001nt-W6 for qemu-devel@nongnu.org; Tue, 09 Oct 2012 08:58:49 -0400 Date: Tue, 9 Oct 2012 23:50:33 +1100 From: David Gibson Message-ID: <20121009125033.GC5798@truffula.fritz.box> References: <1349756259-12975-1-git-send-email-david@gibson.dropbear.id.au> <1349756259-12975-3-git-send-email-david@gibson.dropbear.id.au> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Subject: Re: [Qemu-devel] [Qemu-ppc] [PATCH 2/4] target-ppc: Extend FPU state for newer POWER CPUs List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Alexander Graf Cc: qemu-ppc@nongnu.org, qemu-devel@nongnu.org On Tue, Oct 09, 2012 at 01:41:02PM +0200, Alexander Graf wrote: > On 09.10.2012, at 13:38, Alexander Graf wrote: > > On 09.10.2012, at 06:17, David Gibson wrote: [snip] > > This will still break TCG for qemu-system-ppc64, no? > > To be more precise: > > agraf@lychee:/home/agraf/release/qemu> grep -R cpu_fpscr target-ppc > target-ppc/translate.c:static TCGv_i32 cpu_fpscr; I did update the type of cpu_fpscr.. > target-ppc/translate.c: cpu_fpscr = tcg_global_mem_new_i32(TCG_AREG0, > target-ppc/translate.c: tcg_gen_shri_i32(cpu_crf[crfD(ctx->opcode)], cpu_fpscr, bfa); > target-ppc/translate.c: tcg_gen_andi_i32(cpu_fpscr, cpu_fpscr, ~(0xF << bfa)); > target-ppc/translate.c: tcg_gen_extu_i32_i64(cpu_fpr[rD(ctx->opcode)], cpu_fpscr); > target-ppc/translate.c: tcg_gen_shri_i32(cpu_crf[1], cpu_fpscr, FPSCR_OX); > target-ppc/translate.c: tcg_gen_shri_i32(cpu_crf[1], cpu_fpscr, FPSCR_OX); > target-ppc/translate.c: tcg_gen_shri_i32(cpu_crf[1], cpu_fpscr, FPSCR_OX); > target-ppc/translate.c: tcg_gen_shri_i32(cpu_crf[1], cpu_fpscr, FPSCR_OX); > > All those functions assume cpu_fpscr is a TCGv32. They need to be > adjusted to work on tl instead. But I didn't spot the type dependent calls. I figured type checking would catch that sort of thing, but apparently not. > Please test compile your code with configure --enable-tcg-debug. Ok, will do. -- David Gibson | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_ | _way_ _around_! http://www.ozlabs.org/~dgibson