From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:36879) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TLbWL-0000Jh-NW for qemu-devel@nongnu.org; Tue, 09 Oct 2012 11:15:03 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TLbWF-0004UG-M3 for qemu-devel@nongnu.org; Tue, 09 Oct 2012 11:14:57 -0400 Received: from hall.aurel32.net ([88.191.126.93]:43046) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TLbWF-0004U8-GY for qemu-devel@nongnu.org; Tue, 09 Oct 2012 11:14:51 -0400 Date: Tue, 9 Oct 2012 17:14:45 +0200 From: Aurelien Jarno Message-ID: <20121009151445.GC14078@ohm.aurel32.net> References: <1349202750-16815-1-git-send-email-rth@twiddle.net> <1349202750-16815-3-git-send-email-rth@twiddle.net> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-15 Content-Disposition: inline In-Reply-To: <1349202750-16815-3-git-send-email-rth@twiddle.net> Subject: Re: [Qemu-devel] [PATCH 02/10] tcg: Canonicalize add2 operand ordering List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Richard Henderson Cc: qemu-devel@nongnu.org On Tue, Oct 02, 2012 at 11:32:22AM -0700, Richard Henderson wrote: > Signed-off-by: Richard Henderson > --- > tcg/optimize.c | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/tcg/optimize.c b/tcg/optimize.c > index 5e0504a..3539826 100644 > --- a/tcg/optimize.c > +++ b/tcg/optimize.c > @@ -472,6 +472,11 @@ static TCGArg *tcg_constant_folding(TCGContext *s, uint16_t *tcg_opc_ptr, > if (swap_commutative(args[0], &args[4], &args[3])) { > args[5] = tcg_invert_cond(args[5]); > } > + break; > + case INDEX_op_add2_i32: > + swap_commutative(args[0], &args[2], &args[4]); > + swap_commutative(args[1], &args[3], &args[5]); > + break; > default: > break; > } Reviewed-by: Aurelien Jarno -- Aurelien Jarno GPG: 1024D/F1BCDB73 aurelien@aurel32.net http://www.aurel32.net