From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:55032) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TLcrT-0002pB-VH for qemu-devel@nongnu.org; Tue, 09 Oct 2012 12:40:53 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TLcrR-0005wu-Q7 for qemu-devel@nongnu.org; Tue, 09 Oct 2012 12:40:51 -0400 Received: from hall.aurel32.net ([88.191.126.93]:45645) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TLcrR-0005vk-IA for qemu-devel@nongnu.org; Tue, 09 Oct 2012 12:40:49 -0400 Date: Tue, 9 Oct 2012 18:32:33 +0200 From: Aurelien Jarno Message-ID: <20121009163233.GB9643@ohm.aurel32.net> References: <1349202750-16815-1-git-send-email-rth@twiddle.net> <1349202750-16815-6-git-send-email-rth@twiddle.net> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-15 Content-Disposition: inline In-Reply-To: <1349202750-16815-6-git-send-email-rth@twiddle.net> Subject: Re: [Qemu-devel] [PATCH 05/10] tcg: Optimize double-word comparisons against zero List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Richard Henderson Cc: qemu-devel@nongnu.org On Tue, Oct 02, 2012 at 11:32:25AM -0700, Richard Henderson wrote: > Signed-off-by: Richard Henderson > --- > tcg/optimize.c | 39 +++++++++++++++++++++++++++++++++++++++ > 1 file changed, 39 insertions(+) > > diff --git a/tcg/optimize.c b/tcg/optimize.c > index 592d166..5804b66 100644 > --- a/tcg/optimize.c > +++ b/tcg/optimize.c > @@ -746,6 +746,45 @@ static TCGArg *tcg_constant_folding(TCGContext *s, uint16_t *tcg_opc_ptr, > } > goto do_default; > > + case INDEX_op_brcond2_i32: > + /* Simplify LT/GE comparisons vs zero to a single compare > + vs the high word of the input. */ > + if ((args[4] == TCG_COND_LT || args[4] == TCG_COND_GE) > + && temps[args[2]].state == TCG_TEMP_CONST > + && temps[args[3]].state == TCG_TEMP_CONST > + && temps[args[2]].val == 0 > + && temps[args[3]].val == 0) { > + gen_opc_buf[op_index] = INDEX_op_brcond_i32; > + gen_args[0] = args[1]; > + gen_args[1] = args[3]; > + gen_args[2] = args[4]; > + gen_args[3] = args[5]; > + gen_args += 4; > + args += 6; > + memset(temps, 0, nb_temps * sizeof(struct tcg_temp_info)); > + break; > + } > + goto do_default; > + > + case INDEX_op_setcond2_i32: > + /* Simplify LT/GE comparisons vs zero to a single compare > + vs the high word of the input. */ > + if ((args[5] == TCG_COND_LT || args[5] == TCG_COND_GE) > + && temps[args[3]].state == TCG_TEMP_CONST > + && temps[args[4]].state == TCG_TEMP_CONST > + && temps[args[3]].val == 0 > + && temps[args[4]].val == 0) { > + gen_opc_buf[op_index] = INDEX_op_setcond_i32; > + gen_args[0] = args[0]; > + gen_args[1] = args[2]; > + gen_args[2] = args[4]; > + gen_args[3] = args[5]; > + gen_args += 4; > + args += 6; > + break; > + } > + goto do_default; > + > case INDEX_op_call: > nb_call_args = (args[0] >> 16) + (args[0] & 0xffff); > if (!(args[nb_call_args + 1] & (TCG_CALL_CONST | TCG_CALL_PURE))) { Reviewed-by: Aurelien Jarno -- Aurelien Jarno GPG: 1024D/F1BCDB73 aurelien@aurel32.net http://www.aurel32.net