From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:36331) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TLgM0-00052j-G1 for qemu-devel@nongnu.org; Tue, 09 Oct 2012 16:24:37 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TLgLp-0002Fy-Tg for qemu-devel@nongnu.org; Tue, 09 Oct 2012 16:24:36 -0400 Received: from hall.aurel32.net ([88.191.126.93]:36517) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TLgLp-0002FV-Nf for qemu-devel@nongnu.org; Tue, 09 Oct 2012 16:24:25 -0400 Date: Tue, 9 Oct 2012 22:24:21 +0200 From: Aurelien Jarno Message-ID: <20121009202421.GI9643@ohm.aurel32.net> References: <1349812584-19551-1-git-send-email-aurelien@aurel32.net> <1349812584-19551-15-git-send-email-aurelien@aurel32.net> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-15 Content-Disposition: inline In-Reply-To: Subject: Re: [Qemu-devel] [PATCH v2 14/26] tcg: rework TCG helper flags List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Maydell Cc: qemu-devel@nongnu.org On Tue, Oct 09, 2012 at 09:04:24PM +0100, Peter Maydell wrote: > On 9 October 2012 20:56, Aurelien Jarno wrote: > > +#define TCG_CALL_NO_RGSE (TCG_CALL_NO_RG | TCG_CALL_NO_SE) > > When I first read this (in the target-arm patch) I assumed it had > to be a typo for NO_REGS... > > (alas I can't think of a better name) > The idea is to provide short names, so that the definitions in helper.h do not get more than 80 characters, and thus do not become multi-lines. I am opened to suggestions there. Maybe NO_RG_SE? -- Aurelien Jarno GPG: 1024D/F1BCDB73 aurelien@aurel32.net http://www.aurel32.net