Re: [Qemu-devel] [PATCH v2 17/26] target-cris: rename helper flags

["Edgar E. Iglesias" <edgar.iglesias@gmail.com>]

On Tue, Oct 09, 2012 at 09:56:15PM +0200, Aurelien Jarno wrote:
> Rename helper flags to the new ones. This is purely a mechanical change,
> it's possible to use better flags by looking at the helpers.
> 
> Cc: Edgar E. Iglesias <edgar.iglesias@gmail.com>
> Signed-off-by: Aurelien Jarno <aurelien@aurel32.net>
> ---
>  target-cris/helper.h |   18 +++++++++---------
>  1 file changed, 9 insertions(+), 9 deletions(-)
> 
> diff --git a/target-cris/helper.h b/target-cris/helper.h
> index 99fb326..fe12083 100644
> --- a/target-cris/helper.h
> +++ b/target-cris/helper.h
> @@ -10,19 +10,19 @@ DEF_HELPER_1(rfn, void, env);
>  DEF_HELPER_3(movl_sreg_reg, void, env, i32, i32)
>  DEF_HELPER_3(movl_reg_sreg, void, env, i32, i32)
>  
> -DEF_HELPER_FLAGS_1(lz, TCG_CALL_PURE, i32, i32);
> -DEF_HELPER_FLAGS_4(btst, TCG_CALL_PURE, i32, env, i32, i32, i32);
> +DEF_HELPER_FLAGS_1(lz, TCG_CALL_NO_SE, i32, i32);


btw, lz could be TCG_CALL_NO_RGSE like in the microblaze case.
I guess the _CONST was missing from before...





> +DEF_HELPER_FLAGS_4(btst, TCG_CALL_NO_SE, i32, env, i32, i32, i32);
>  
> -DEF_HELPER_FLAGS_4(evaluate_flags_muls, TCG_CALL_PURE, i32, env, i32, i32, i32)
> -DEF_HELPER_FLAGS_4(evaluate_flags_mulu, TCG_CALL_PURE, i32, env, i32, i32, i32)
> -DEF_HELPER_FLAGS_5(evaluate_flags_mcp, TCG_CALL_PURE, i32, env,
> +DEF_HELPER_FLAGS_4(evaluate_flags_muls, TCG_CALL_NO_SE, i32, env, i32, i32, i32)
> +DEF_HELPER_FLAGS_4(evaluate_flags_mulu, TCG_CALL_NO_SE, i32, env, i32, i32, i32)
> +DEF_HELPER_FLAGS_5(evaluate_flags_mcp, TCG_CALL_NO_SE, i32, env,
>                                                        i32, i32, i32, i32)
> -DEF_HELPER_FLAGS_5(evaluate_flags_alu_4, TCG_CALL_PURE, i32, env,
> +DEF_HELPER_FLAGS_5(evaluate_flags_alu_4, TCG_CALL_NO_SE, i32, env,
>                                                          i32, i32, i32, i32)
> -DEF_HELPER_FLAGS_5(evaluate_flags_sub_4, TCG_CALL_PURE, i32, env,
> +DEF_HELPER_FLAGS_5(evaluate_flags_sub_4, TCG_CALL_NO_SE, i32, env,
>                                                          i32, i32, i32, i32)
> -DEF_HELPER_FLAGS_3(evaluate_flags_move_4, TCG_CALL_PURE, i32, env, i32, i32)
> -DEF_HELPER_FLAGS_3(evaluate_flags_move_2, TCG_CALL_PURE, i32, env, i32, i32)
> +DEF_HELPER_FLAGS_3(evaluate_flags_move_4, TCG_CALL_NO_SE, i32, env, i32, i32)
> +DEF_HELPER_FLAGS_3(evaluate_flags_move_2, TCG_CALL_NO_SE, i32, env, i32, i32)
>  DEF_HELPER_1(evaluate_flags, void, env)
>  DEF_HELPER_1(top_evaluate_flags, void, env)
>  
> -- 
> 1.7.10.4
>