From: Marcelo Tosatti <mtosatti@redhat.com>
To: Don Slutz <Don@cloudswitch.com>
Cc: peter.maydell@linaro.org, ehabkost@redhat.com,
kvm@vger.kernel.org, qemu-devel@nongnu.org, avi@redhat.com,
anthony@codemonkey.ws, imammedo@redhat.com, afaerber@suse.de
Subject: Re: [Qemu-devel] [PATCH v6 05/16] target-i386: Use Hypervisor level in -machine pc, accel=kvm.
Date: Wed, 10 Oct 2012 11:08:05 -0300 [thread overview]
Message-ID: <20121010140805.GA19764@amt.cnet> (raw)
In-Reply-To: <50757218.6080503@CloudSwitch.Com>
On Wed, Oct 10, 2012 at 09:03:20AM -0400, Don Slutz wrote:
> >>Did you mean 3 patch sets (or more)? Or just a different order?
> >> -Don Slutz
> >Different order. Patches should be logically related (think of what
> >information the reviewer needs). Please write changelogs for
> >every patch.
> >
> >
> Using this order causes support for Hyper-V to stop working in the
> middle of the patch set. How about this order:
> 1) Create object properties.
> 2) Convert Hyper-V to set the new properties.
> 3) Change kvm.c to use the new properties.
> 4) Export VMWare CPUID via properties.
>
> 5) Change accel=tcg to use the new properties.
>
> -Don Slutz
Fine, as long as change from item A) does not leak to item B).
next prev parent reply other threads:[~2012-10-10 14:08 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-24 14:32 [Qemu-devel] [PATCH v6 00/16] Allow changing of Hypervisor CPUIDs Don Slutz
2012-09-24 14:32 ` [Qemu-devel] [PATCH v6 01/16] target-i386: Add missing kvm bits Don Slutz
2012-09-24 14:32 ` [Qemu-devel] [PATCH v6 02/16] target-i386: Add Hypervisor level Don Slutz
2012-09-24 14:32 ` [Qemu-devel] [PATCH v6 03/16] target-i386: Add cpu object access routines for " Don Slutz
[not found] ` <20121009162520.GB12330@amt.cnet>
2012-10-09 19:13 ` Don Slutz
2012-10-10 15:22 ` Don Slutz
2012-10-10 15:40 ` Andreas Färber
2012-10-11 22:20 ` Don Slutz
2012-09-24 14:32 ` [Qemu-devel] [PATCH v6 04/16] target-i386: Add x86_set_hyperv Don Slutz
[not found] ` <20121009163409.GC12330@amt.cnet>
2012-10-09 17:17 ` Marcelo Tosatti
2012-10-09 19:12 ` Don Slutz
2012-10-09 19:15 ` Marcelo Tosatti
2012-09-24 14:32 ` [Qemu-devel] [PATCH v6 05/16] target-i386: Use Hypervisor level in -machine pc, accel=kvm Don Slutz
2012-10-09 17:18 ` Marcelo Tosatti
2012-10-09 18:27 ` Marcelo Tosatti
2012-10-09 18:47 ` Marcelo Tosatti
2012-10-09 19:09 ` Don Slutz
2012-10-09 19:11 ` Marcelo Tosatti
2012-10-10 13:03 ` Don Slutz
2012-10-10 14:08 ` Marcelo Tosatti [this message]
2012-09-24 14:32 ` [Qemu-devel] [PATCH v6 06/16] target-i386: Use Hypervisor level in -machine pc, accel=tcg Don Slutz
2012-10-09 19:01 ` Marcelo Tosatti
2012-10-10 13:07 ` Don Slutz
2012-09-24 14:32 ` [Qemu-devel] [PATCH v6 07/16] target-i386: Add Hypervisor vendor Don Slutz
2012-09-24 14:32 ` [Qemu-devel] [PATCH v6 08/16] target-i386: Add cpu object access routines for " Don Slutz
2012-10-09 19:02 ` Marcelo Tosatti
2012-09-24 14:32 ` [Qemu-devel] [PATCH v6 09/16] target-i386: Use Hypervisor vendor in -machine pc, accel=kvm Don Slutz
2012-09-24 14:32 ` [Qemu-devel] [PATCH v6 10/16] target-i386: Use Hypervisor vendor in -machine pc, accel=tcg Don Slutz
2012-09-24 14:32 ` [Qemu-devel] [PATCH v6 11/16] target-i386: Add some known names to Hypervisor vendor Don Slutz
2012-09-24 14:32 ` [Qemu-devel] [PATCH v6 12/16] target-i386: Add optional Hypervisor leaf extra Don Slutz
2012-09-24 14:32 ` [Qemu-devel] [PATCH v6 13/16] target-i386: Add cpu object access routines for " Don Slutz
2012-09-24 14:32 ` [Qemu-devel] [PATCH v6 14/16] target-i386: Add setting of Hypervisor leaf extra for known vmare4 Don Slutz
2012-10-09 19:09 ` Marcelo Tosatti
2012-09-24 14:32 ` [Qemu-devel] [PATCH v6 15/16] target-i386: Use Hypervisor leaf extra in -machine pc, accel=kvm Don Slutz
2012-09-24 14:32 ` [Qemu-devel] [PATCH v6 16/16] target-i386: Use Hypervisor leaf extra in -machine pc, accel=tcg Don Slutz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121010140805.GA19764@amt.cnet \
--to=mtosatti@redhat.com \
--cc=Don@cloudswitch.com \
--cc=afaerber@suse.de \
--cc=anthony@codemonkey.ws \
--cc=avi@redhat.com \
--cc=ehabkost@redhat.com \
--cc=imammedo@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).