From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:56291)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mtosatti@redhat.com>) id 1TLwxp-0006i0-BP
	for qemu-devel@nongnu.org; Wed, 10 Oct 2012 10:08:46 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <mtosatti@redhat.com>) id 1TLwxf-000409-TW
	for qemu-devel@nongnu.org; Wed, 10 Oct 2012 10:08:45 -0400
Received: from mx1.redhat.com ([209.132.183.28]:62449)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mtosatti@redhat.com>) id 1TLwxf-000401-LE
	for qemu-devel@nongnu.org; Wed, 10 Oct 2012 10:08:35 -0400
Date: Wed, 10 Oct 2012 11:08:05 -0300
From: Marcelo Tosatti <mtosatti@redhat.com>
Message-ID: <20121010140805.GA19764@amt.cnet>
References: <1348497138-2516-1-git-send-email-Don@CloudSwitch.com>
	<1348497138-2516-6-git-send-email-Don@CloudSwitch.com>
	<20121009171805.GA26004@amt.cnet> <20121009182726.GA27536@amt.cnet>
	<20121009184753.GA1403@amt.cnet> <5074765D.8000208@CloudSwitch.Com>
	<20121009191136.GD2927@amt.cnet> <50757218.6080503@CloudSwitch.Com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <50757218.6080503@CloudSwitch.Com>
Subject: Re: [Qemu-devel] [PATCH v6 05/16] target-i386: Use Hypervisor level
 in -machine pc, accel=kvm.
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Don Slutz <Don@cloudswitch.com>
Cc: peter.maydell@linaro.org, ehabkost@redhat.com, kvm@vger.kernel.org, qemu-devel@nongnu.org, avi@redhat.com, anthony@codemonkey.ws, imammedo@redhat.com, afaerber@suse.de

On Wed, Oct 10, 2012 at 09:03:20AM -0400, Don Slutz wrote:
> >>Did you mean 3 patch sets (or more)? Or just a different order?
> >>    -Don Slutz
> >Different order. Patches should be logically related (think of what
> >information the reviewer needs). Please write changelogs for
> >every patch.
> >
> >
> Using this order causes support for Hyper-V to stop working in the
> middle of the patch set.  How about this order:
> 1) Create object properties.
> 2) Convert Hyper-V to set the new properties.
> 3) Change kvm.c to use the new properties.
> 4) Export VMWare CPUID via properties.
> 
> 5) Change accel=tcg to use the new properties.
> 
>    -Don Slutz

Fine, as long as change from item A) does not leak to item B).