From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:33644) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TMJdr-0006ld-MM for qemu-devel@nongnu.org; Thu, 11 Oct 2012 10:21:49 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TMJdh-0002tD-Ca for qemu-devel@nongnu.org; Thu, 11 Oct 2012 10:21:39 -0400 Received: from mx1.redhat.com ([209.132.183.28]:6311) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TMJdh-0002sc-4C for qemu-devel@nongnu.org; Thu, 11 Oct 2012 10:21:29 -0400 Date: Thu, 11 Oct 2012 10:21:22 -0400 From: Jason Baron Message-ID: <20121011142122.GH3592@redhat.com> References: <20121011105705.GE5552@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20121011105705.GE5552@redhat.com> Subject: Re: [Qemu-devel] [PATCH v2 21/21] q35: add acpi-based pci hotplug. List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Michael S. Tsirkin" Cc: agraf@suse.de, aliguori@us.ibm.com, juzhang@redhat.com, jan.kiszka@siemens.com, qemu-devel@nongnu.org, armbru@redhat.com, blauwirbel@gmail.com, yamahata@valinux.co.jp, alex.williamson@redhat.com, kevin@koconnor.net, avi@redhat.com, mkletzan@redhat.com, pbonzini@redhat.com, lcapitulino@redhat.com, afaerber@suse.de, kraxel@redhat.com On Thu, Oct 11, 2012 at 12:57:06PM +0200, Michael S. Tsirkin wrote: > On Mon, Oct 08, 2012 at 11:30:39PM -0400, Jason Baron wrote: > > From: Jason Baron > > > > Add piix style acpi hotplug to q35. > > > > Signed-off-by: Jason Baron > > Something I don't understand here: this only handles hotplug > of devices behind the root, no? > Don't we need support for hotplug/hot remove of devices behind > bridges? > Yes, this only handles acpi hotplug of devices behind the root. I'm trying to reach minimal set of q35 patches that we can build upon. I think that this patch gives us at least the same functionality as piix does. (Plus there is pcie hotplug). As you know, I have a proof of concept patch series providing a second level of hotplug behind bridges. Unfortunately, it was based on the static acpi tables, before Paolo made the hotplug table generation dynamic. So it needs quite a bit of re-work. But I know that it should work :) Thanks, -Jason