From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:57814) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TMKsF-0002By-VE for qemu-devel@nongnu.org; Thu, 11 Oct 2012 11:40:43 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TMKs8-0006mq-37 for qemu-devel@nongnu.org; Thu, 11 Oct 2012 11:40:35 -0400 Received: from mx1.redhat.com ([209.132.183.28]:52449) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TMKs7-0006mj-R0 for qemu-devel@nongnu.org; Thu, 11 Oct 2012 11:40:28 -0400 Date: Thu, 11 Oct 2012 11:40:23 -0400 From: Jason Baron Message-ID: <20121011154023.GJ3592@redhat.com> References: <20121011105705.GE5552@redhat.com> <20121011142122.GH3592@redhat.com> <20121011144656.GF8983@redhat.com> <5076DDBD.50903@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <5076DDBD.50903@redhat.com> Subject: Re: [Qemu-devel] [PATCH v2 21/21] q35: add acpi-based pci hotplug. List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini Cc: aliguori@us.ibm.com, alex.williamson@redhat.com, "Michael S. Tsirkin" , jan.kiszka@siemens.com, qemu-devel@nongnu.org, agraf@suse.de, blauwirbel@gmail.com, yamahata@valinux.co.jp, juzhang@redhat.com, kevin@koconnor.net, avi@redhat.com, mkletzan@redhat.com, lcapitulino@redhat.com, afaerber@suse.de, armbru@redhat.com, kraxel@redhat.com On Thu, Oct 11, 2012 at 04:54:53PM +0200, Paolo Bonzini wrote: > Il 11/10/2012 16:46, Michael S. Tsirkin ha scritto: > > Yes. Reason I ask is because q35 is adding bridges by default now. > > Would it be possible to only add them if requested on command line by user > > instead? > > Can you just use shpc or pcie hotplug on those bridges? > Yes, I've tested pcie hotplug minimally, but it seems to work so far. > > I realize some guests expect devices at specific slots > > but this does not apply to bridges I think? > > > > It would also be nice to add comments explaining why > > specific slots were selected e.g. /* BSD XYZ fails to boot unless ahci is at alow 2 */ > > etc. > > > > Also - will adding this code now mean that when adding bridges > > we'll need to add compatibility code in bios/qemu in the future? > > It will need SSDT changes. One ugliness of Jason's patch was that it > introduced a massive chain of 32*32 Ifs in the SSDT. Changing it to use > LoadTable shouldn't be hard. Then you can patch out the LoadTable (e.g. > _INI -> INI_) based on what QEMU tells you is a bridge or not. > > Paolo >