From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:46381) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TMT5x-0001ki-24 for qemu-devel@nongnu.org; Thu, 11 Oct 2012 20:27:18 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TMT5v-0000fk-NB for qemu-devel@nongnu.org; Thu, 11 Oct 2012 20:27:17 -0400 Received: from e23smtp06.au.ibm.com ([202.81.31.148]:57588) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TMT5v-0000fB-5p for qemu-devel@nongnu.org; Thu, 11 Oct 2012 20:27:15 -0400 Received: from /spool/local by e23smtp06.au.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Fri, 12 Oct 2012 10:25:22 +1000 Date: Fri, 12 Oct 2012 10:28:06 +1000 From: David Gibson Message-ID: <20121012002806.GP25270@truffula.fritz.box> References: <1349921082-980-1-git-send-email-aviksil@linux.vnet.ibm.com> <20121011225934.GL25270@truffula.fritz.box> <1DCDCFB3-839C-4BF8-A89C-29FCD362E841@suse.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1DCDCFB3-839C-4BF8-A89C-29FCD362E841@suse.de> Subject: Re: [Qemu-devel] [PATCH] Add nvram to default boot device list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Alexander Graf Cc: Nikunj A Dadhania , Gleb Natapov , qemu-devel qemu-devel , qemu-ppc List , Avik Sil , Anthony Liguori On Fri, Oct 12, 2012 at 02:03:00AM +0200, Alexander Graf wrote: > > On 12.10.2012, at 00:59, David Gibson wrote: > > > On Thu, Oct 11, 2012 at 07:34:42AM +0530, Avik Sil wrote: > >> This patch adds nvram specified boot device into qemu default > >> boot_devices list. This helps firmware to boot from nvram specified > >> boot device if no -boot option is specified. > > > > I really don't think this is a good idea, it extends an already > > deprecated mechanism in a fuzzy way and requires careful checking to > > see if it could break anything. On all platforms the boot sequence > > should be: > > if bootindex is specified: > > boot according to bootindex > > else if -boot is specified: > > boot according to -boot sequence > > else: > > use platform firmware default sequence > > > > The last will of course vary by platform, and could depend on platform > > details like the contents of NVRAM. Your original idea of making it > > clear to the guest when -boot has been specified (as opposed to when > > it contains its default value) was the right one, and this "x" in > > -boot is going the wrong direction. > > Given that this is a fundamental direction for a bunch of machines, > how about we talk about it on the weekly QEMU call? Uh, is this a call I know about? -- David Gibson | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_ | _way_ _around_! http://www.ozlabs.org/~dgibson