From: Igor Mammedov <imammedo@redhat.com>
To: "Andreas Färber" <afaerber@suse.de>
Cc: jan.kiszka@siemens.com, aliguori@us.ibm.com,
qemu-devel@nongnu.org, ehabkost@redhat.com
Subject: Re: [Qemu-devel] [PATCH v5] target-i386: initialize APIC at CPU level
Date: Mon, 15 Oct 2012 15:05:52 +0200 [thread overview]
Message-ID: <20121015150552.4d46f708@nial.usersys.redhat.com> (raw)
In-Reply-To: <507C0880.4080601@suse.de>
On Mon, 15 Oct 2012 14:58:40 +0200
Andreas Färber <afaerber@suse.de> wrote:
> Am 15.10.2012 13:54, schrieb Igor Mammedov:
> > On Sun, 14 Oct 2012 06:09:56 +0200
> > Andreas Färber <afaerber@suse.de> wrote:
> >
> >> Am 13.10.2012 22:35, schrieb Igor Mammedov:
> >>> (L)APIC is a part of cpu [1] so move APIC initialization inside of
> >>> x86_cpu object. Since cpu_model and override flags currently specify
> >>> whether APIC should be created or not, APIC creation&initialization is
> >>> moved into x86_cpu_apic_init() which is called from x86_cpu_realize().
> >>>
> >>> [1] - all x86 cpus have integrated APIC if we overlook existence of
> >>> i486, and it's more convenient to model after majority of them.
> >>>
> >>> Signed-off-by: Igor Mammedov <imammedo@redhat.com>
> >>> ---
> >>> v5: fix *-user target build, smp_cpus is defined for softmmu only
> >>
> >> I do not run into any build issue with v4. Is it a runtime issue?
> >>
> >> Andreas
> >>
> > I've run into this trying to build your latest CPUstate series with
> > following configure options:
> > './configure' '--enable-debug'
> > '--target-list=x86_64-softmmu,x86_64-linux-user'
>
> --enable-debug was the missing puzzle piece, now I get the undefined
> reference warning, too. :)
>
> > Anyway it's better not to build in any APIC checks in user target since it
> > doesn't need it at all.
> >
> > I'm sorry for not noticing error earlier at v4 build time.
> > Could you re-apply it, please?
>
> Sure, the patch itself is indeed better. Now that I've been able to
> reproduce, I've exchanged v4 against v5 in on qom-cpu queue:
> https://github.com/afaerber/qemu-cpu/commits/qom-cpu
Thanks.
>
> Thanks for noticing,
> Andreas
>
prev parent reply other threads:[~2012-10-15 13:06 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-13 20:35 [Qemu-devel] [PATCH v5] target-i386: initialize APIC at CPU level Igor Mammedov
2012-10-14 4:09 ` Andreas Färber
2012-10-15 11:54 ` Igor Mammedov
2012-10-15 12:58 ` Andreas Färber
2012-10-15 13:05 ` Igor Mammedov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121015150552.4d46f708@nial.usersys.redhat.com \
--to=imammedo@redhat.com \
--cc=afaerber@suse.de \
--cc=aliguori@us.ibm.com \
--cc=ehabkost@redhat.com \
--cc=jan.kiszka@siemens.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).