From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:51212) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TNkMu-0001H4-CJ for qemu-devel@nongnu.org; Mon, 15 Oct 2012 09:06:09 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TNkMn-0004P9-HF for qemu-devel@nongnu.org; Mon, 15 Oct 2012 09:06:04 -0400 Received: from mx1.redhat.com ([209.132.183.28]:40448) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TNkMn-0004P4-88 for qemu-devel@nongnu.org; Mon, 15 Oct 2012 09:05:57 -0400 Date: Mon, 15 Oct 2012 15:05:52 +0200 From: Igor Mammedov Message-ID: <20121015150552.4d46f708@nial.usersys.redhat.com> In-Reply-To: <507C0880.4080601@suse.de> References: <1350160539-22293-1-git-send-email-imammedo@redhat.com> <507A3B14.3050502@suse.de> <20121015135434.62d4965d@nial.usersys.redhat.com> <507C0880.4080601@suse.de> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH v5] target-i386: initialize APIC at CPU level List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Andreas =?ISO-8859-1?B?RuRyYmVy?= Cc: jan.kiszka@siemens.com, aliguori@us.ibm.com, qemu-devel@nongnu.org, ehabkost@redhat.com On Mon, 15 Oct 2012 14:58:40 +0200 Andreas F=E4rber wrote: > Am 15.10.2012 13:54, schrieb Igor Mammedov: > > On Sun, 14 Oct 2012 06:09:56 +0200 > > Andreas F=E4rber wrote: > >=20 > >> Am 13.10.2012 22:35, schrieb Igor Mammedov: > >>> (L)APIC is a part of cpu [1] so move APIC initialization inside of > >>> x86_cpu object. Since cpu_model and override flags currently specify > >>> whether APIC should be created or not, APIC creation&initialization is > >>> moved into x86_cpu_apic_init() which is called from x86_cpu_realize(). > >>> > >>> [1] - all x86 cpus have integrated APIC if we overlook existence of > >>> i486, and it's more convenient to model after majority of them. > >>> > >>> Signed-off-by: Igor Mammedov > >>> --- > >>> v5: fix *-user target build, smp_cpus is defined for softmmu only > >> > >> I do not run into any build issue with v4. Is it a runtime issue? > >> > >> Andreas > >> > > I've run into this trying to build your latest CPUstate series with > > following configure options: > > './configure' '--enable-debug' > > '--target-list=3Dx86_64-softmmu,x86_64-linux-user' >=20 > --enable-debug was the missing puzzle piece, now I get the undefined > reference warning, too. :) >=20 > > Anyway it's better not to build in any APIC checks in user target since= it > > doesn't need it at all. > >=20 > > I'm sorry for not noticing error earlier at v4 build time. > > Could you re-apply it, please? >=20 > Sure, the patch itself is indeed better. Now that I've been able to > reproduce, I've exchanged v4 against v5 in on qom-cpu queue: > https://github.com/afaerber/qemu-cpu/commits/qom-cpu Thanks. >=20 > Thanks for noticing, > Andreas >=20