From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:40299)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <lcapitulino@redhat.com>) id 1TNpqY-0002OT-Bn
	for qemu-devel@nongnu.org; Mon, 15 Oct 2012 14:57:03 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <lcapitulino@redhat.com>) id 1TNpqX-0004tN-CX
	for qemu-devel@nongnu.org; Mon, 15 Oct 2012 14:57:02 -0400
Received: from mx1.redhat.com ([209.132.183.28]:27759)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <lcapitulino@redhat.com>) id 1TNpqX-0004tI-4T
	for qemu-devel@nongnu.org; Mon, 15 Oct 2012 14:57:01 -0400
Date: Mon, 15 Oct 2012 15:57:54 -0300
From: Luiz Capitulino <lcapitulino@redhat.com>
Message-ID: <20121015155754.54f11e01@doriath.home>
In-Reply-To: <20121005164758.4808b2d1@doriath.home>
References: <20121005164758.4808b2d1@doriath.home>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH] Call MADV_HUGEPAGE for guest RAM
	allocations
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: aliguori@us.ibm.com
Cc: aarcange@redhat.com, jan.kiszka@siemens.com, qemu-devel <qemu-devel@nongnu.org>

On Fri, 5 Oct 2012 16:47:57 -0300
Luiz Capitulino <lcapitulino@redhat.com> wrote:

> This makes it possible for QEMU to use transparent huge pages (THP)
> when transparent_hugepage/enabled=madvise. Otherwise THP is only
> used when it's enabled system wide.
> 
> Signed-off-by: Luiz Capitulino <lcapitulino@redhat.com>

ping?

> ---
>  exec.c  | 1 +
>  osdep.h | 5 +++++
>  2 files changed, 6 insertions(+)
> 
> diff --git a/exec.c b/exec.c
> index 1114a09..7504909 100644
> --- a/exec.c
> +++ b/exec.c
> @@ -2584,6 +2584,7 @@ ram_addr_t qemu_ram_alloc_from_ptr(ram_addr_t size, void *host,
>      cpu_physical_memory_set_dirty_range(new_block->offset, size, 0xff);
>  
>      qemu_ram_setup_dump(new_block->host, size);
> +    qemu_madvise(new_block->host, size, QEMU_MADV_HUGEPAGE);
>  
>      if (kvm_enabled())
>          kvm_setup_guest_memory(new_block->host, size);
> diff --git a/osdep.h b/osdep.h
> index cb213e0..c5fd3d9 100644
> --- a/osdep.h
> +++ b/osdep.h
> @@ -108,6 +108,11 @@ void qemu_vfree(void *ptr);
>  #else
>  #define QEMU_MADV_DONTDUMP QEMU_MADV_INVALID
>  #endif
> +#ifdef MADV_HUGEPAGE
> +#define QEMU_MADV_HUGEPAGE MADV_HUGEPAGE
> +#else
> +#define QEMU_MADV_HUGEPAGE QEMU_MADV_INVALID
> +#endif
>  
>  #elif defined(CONFIG_POSIX_MADVISE)
>