From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:54082) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TNvPJ-0004PM-H3 for qemu-devel@nongnu.org; Mon, 15 Oct 2012 20:53:18 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TNvPI-0007CA-HF for qemu-devel@nongnu.org; Mon, 15 Oct 2012 20:53:17 -0400 Received: from mx1.redhat.com ([209.132.183.28]:21964) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TNvPI-0007C5-6n for qemu-devel@nongnu.org; Mon, 15 Oct 2012 20:53:16 -0400 Date: Tue, 16 Oct 2012 02:53:12 +0200 From: Igor Mammedov Message-ID: <20121016025312.2db8b582@thinkpad.mammed.net> In-Reply-To: <1350005203-15405-6-git-send-email-afaerber@suse.de> References: <1350005203-15405-1-git-send-email-afaerber@suse.de> <1350005203-15405-6-git-send-email-afaerber@suse.de> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH qom-cpu v2 5/7] cpus: Pass CPUState to qemu_cpu_kick_thread() List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Andreas =?UTF-8?B?RsOkcmJlcg==?= Cc: qemu-devel@nongnu.org On Fri, 12 Oct 2012 03:26:41 +0200 Andreas F=C3=A4rber wrote: > CPUArchState is no longer needed there. >=20 > Signed-off-by: Andreas F=C3=A4rber > --- > cpus.c | 9 ++++----- > 1 Datei ge=C3=A4ndert, 4 Zeilen hinzugef=C3=BCgt(+), 5 Zeilen entfernt(-) >=20 > diff --git a/cpus.c b/cpus.c > index 849ea8a..54b765e 100644 > --- a/cpus.c > +++ b/cpus.c > @@ -844,9 +844,8 @@ static void *qemu_tcg_cpu_thread_fn(void *arg) > return NULL; > } > =20 > -static void qemu_cpu_kick_thread(CPUArchState *env) > +static void qemu_cpu_kick_thread(CPUState *cpu) > { > - CPUState *cpu =3D ENV_GET_CPU(env); > #ifndef _WIN32 > int err; > =20 > @@ -871,7 +870,7 @@ void qemu_cpu_kick(void *_env) > =20 > qemu_cond_broadcast(env->halt_cond); > if (!tcg_enabled() && !cpu->thread_kicked) { > - qemu_cpu_kick_thread(env); > + qemu_cpu_kick_thread(cpu); > cpu->thread_kicked =3D true; > } > } > @@ -883,7 +882,7 @@ void qemu_cpu_kick_self(void) > CPUState *cpu_single_cpu =3D ENV_GET_CPU(cpu_single_env); > =20 > if (!cpu_single_cpu->thread_kicked) { > - qemu_cpu_kick_thread(cpu_single_env); > + qemu_cpu_kick_thread(cpu_single_cpu); > cpu_single_cpu->thread_kicked =3D true; > } > #else > @@ -903,7 +902,7 @@ void qemu_mutex_lock_iothread(void) > } else { > iothread_requesting_mutex =3D true; > if (qemu_mutex_trylock(&qemu_global_mutex)) { > - qemu_cpu_kick_thread(first_cpu); > + qemu_cpu_kick_thread(ENV_GET_CPU(first_cpu)); > qemu_mutex_lock(&qemu_global_mutex); > } > iothread_requesting_mutex =3D false; > --=20 > 1.7.10.4 >=20 >=20 Reviewed-by: Igor Mammedov --=20 Regards, Igor