* [Qemu-devel] [PATCH] mm: compaction: Correct the nr_strict_isolated check for CMA
@ 2012-10-16 8:39 Mel Gorman
2012-10-16 12:52 ` Rik van Riel
2012-10-16 13:12 ` Minchan Kim
0 siblings, 2 replies; 3+ messages in thread
From: Mel Gorman @ 2012-10-16 8:39 UTC (permalink / raw)
To: Andrew Morton
Cc: Richard Davies, KVM, Arnd Bergmann, QEMU-devel, LKML, Linux-MM,
Avi Kivity, Shaohua Li, Arm Kernel Mailing List
Thierry reported that the "iron out" patch for isolate_freepages_block()
had problems due to the strict check being too strict with "mm: compaction:
Iron out isolate_freepages_block() and isolate_freepages_range() -fix1".
It's possible that more pages than necessary are isolated but the check
still fails and I missed that this fix was not picked up before RC1. This
same problem has been identified in 3.7-RC1 by Tony Prisk and should be
addressed by the following patch.
Signed-off-by: Mel Gorman <mgorman@suse.de>
Tested-by: Tony Prisk <linux@prisktech.co.nz>
---
mm/compaction.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/mm/compaction.c b/mm/compaction.c
index 2c4ce17..9eef558 100644
--- a/mm/compaction.c
+++ b/mm/compaction.c
@@ -346,7 +346,7 @@ static unsigned long isolate_freepages_block(struct compact_control *cc,
* pages requested were isolated. If there were any failures, 0 is
* returned and CMA will fail.
*/
- if (strict && nr_strict_required != total_isolated)
+ if (strict && nr_strict_required > total_isolated)
total_isolated = 0;
if (locked)
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [Qemu-devel] [PATCH] mm: compaction: Correct the nr_strict_isolated check for CMA
2012-10-16 8:39 [Qemu-devel] [PATCH] mm: compaction: Correct the nr_strict_isolated check for CMA Mel Gorman
@ 2012-10-16 12:52 ` Rik van Riel
2012-10-16 13:12 ` Minchan Kim
1 sibling, 0 replies; 3+ messages in thread
From: Rik van Riel @ 2012-10-16 12:52 UTC (permalink / raw)
To: Mel Gorman
Cc: Richard Davies, KVM, Arnd Bergmann, QEMU-devel, LKML, Linux-MM,
Avi Kivity, Andrew Morton, Shaohua Li, Arm Kernel Mailing List
On 10/16/2012 04:39 AM, Mel Gorman wrote:
> Thierry reported that the "iron out" patch for isolate_freepages_block()
> had problems due to the strict check being too strict with "mm: compaction:
> Iron out isolate_freepages_block() and isolate_freepages_range() -fix1".
> It's possible that more pages than necessary are isolated but the check
> still fails and I missed that this fix was not picked up before RC1. This
> same problem has been identified in 3.7-RC1 by Tony Prisk and should be
> addressed by the following patch.
>
> Signed-off-by: Mel Gorman <mgorman@suse.de>
> Tested-by: Tony Prisk <linux@prisktech.co.nz>
Acked-by: Rik van Riel <riel@redhat.com>
--
All rights reversed
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [Qemu-devel] [PATCH] mm: compaction: Correct the nr_strict_isolated check for CMA
2012-10-16 8:39 [Qemu-devel] [PATCH] mm: compaction: Correct the nr_strict_isolated check for CMA Mel Gorman
2012-10-16 12:52 ` Rik van Riel
@ 2012-10-16 13:12 ` Minchan Kim
1 sibling, 0 replies; 3+ messages in thread
From: Minchan Kim @ 2012-10-16 13:12 UTC (permalink / raw)
To: Mel Gorman
Cc: Richard Davies, KVM, Arnd Bergmann, QEMU-devel, LKML, Linux-MM,
Avi Kivity, Andrew Morton, Shaohua Li, Arm Kernel Mailing List
On Tue, Oct 16, 2012 at 09:39:27AM +0100, Mel Gorman wrote:
> Thierry reported that the "iron out" patch for isolate_freepages_block()
> had problems due to the strict check being too strict with "mm: compaction:
> Iron out isolate_freepages_block() and isolate_freepages_range() -fix1".
> It's possible that more pages than necessary are isolated but the check
> still fails and I missed that this fix was not picked up before RC1. This
> same problem has been identified in 3.7-RC1 by Tony Prisk and should be
> addressed by the following patch.
>
> Signed-off-by: Mel Gorman <mgorman@suse.de>
> Tested-by: Tony Prisk <linux@prisktech.co.nz>
Acked-by: Minchan Kim <minchan@kernel.org>
--
Kind Regards,
Minchan Kim
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2012-10-16 13:12 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-10-16 8:39 [Qemu-devel] [PATCH] mm: compaction: Correct the nr_strict_isolated check for CMA Mel Gorman
2012-10-16 12:52 ` Rik van Riel
2012-10-16 13:12 ` Minchan Kim
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).