From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:55312) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TOWoP-0004px-NI for qemu-devel@nongnu.org; Wed, 17 Oct 2012 12:49:47 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TOWoO-0002de-Kl for qemu-devel@nongnu.org; Wed, 17 Oct 2012 12:49:41 -0400 Received: from mx1.redhat.com ([209.132.183.28]:33284) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TOWoO-0002dU-BC for qemu-devel@nongnu.org; Wed, 17 Oct 2012 12:49:40 -0400 Received: from int-mx12.intmail.prod.int.phx2.redhat.com (int-mx12.intmail.prod.int.phx2.redhat.com [10.5.11.25]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q9HGndrt027818 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Wed, 17 Oct 2012 12:49:39 -0400 Date: Wed, 17 Oct 2012 13:50:35 -0300 From: Luiz Capitulino Message-ID: <20121017135035.4cf65f27@doriath.home> In-Reply-To: <507EE148.10001@redhat.com> References: <1349877786-23514-1-git-send-email-pbonzini@redhat.com> <1349877786-23514-21-git-send-email-pbonzini@redhat.com> <871ugxujzx.fsf@blackfin.pond.sub.org> <507EE148.10001@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 20/25] qapi: add socket address types List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini Cc: Markus Armbruster , qemu-devel@nongnu.org On Wed, 17 Oct 2012 18:48:08 +0200 Paolo Bonzini wrote: > Il 17/10/2012 18:43, Markus Armbruster ha scritto: > > Paolo Bonzini writes: > > > >> Acked-by: Luiz Capitulino > >> Signed-off-by: Paolo Bonzini > >> --- > >> qapi-schema.json | 53 +++++++++++++++++++++++++++++++++++++++++++++++++++++ > >> 1 file modificato, 53 inserzioni(+) > >> > >> diff --git a/qapi-schema.json b/qapi-schema.json > >> index f9dbdae..d40b5fc 100644 > >> --- a/qapi-schema.json > >> +++ b/qapi-schema.json > >> @@ -2505,6 +2505,59 @@ > >> 'opts': 'NetClientOptions' } } > >> > >> ## > >> +# @IPSocketAddress > >> +# > >> +# Captures the destination address of an IP socket > > > > What's a "destination address of an IP socket"? > > Any suggestions? > > >> +# > >> +# @host: host part of the address > >> +# > >> +# @port: port part of the address, or lowest port if @to is present > >> +# > >> +# @to: highest port to try > >> +# > >> +# @ipv4: whether to accept IPv4 addresses, default try both IPv4 and IPv6 > >> +# #optional > >> +# > >> +# @ipv6: whether to accept IPv6 addresses, default try both IPv4 and IPv6 > >> +# #optional > >> +# > >> +# Since 1.3 > >> +## > >> +{ 'type': 'IPSocketAddress', > >> + 'data': { > >> + 'host': 'str', > >> + 'port': 'str', > >> + '*to': 'uint16', > > > > Two port members, one is 'str', the other is 'uint16'. Ugly. > > This is because port can be a service name. Using a union was deemed > overkill. > > >> + '*ipv4': 'bool', > >> + '*ipv6': 'bool' } } > >> + > >> +## > >> +# @UnixSocketAddress > >> +# > >> +# Captures the destination address of a Unix socket > > > > What's a "destination address of a Unix socket"? > > > >> +# > >> +# @path: filesystem path to use > >> +# > >> +# Since 1.3 > >> +## > >> +{ 'type': 'UnixSocketAddress', > >> + 'data': { > >> + 'path': 'str' } } > >> + > >> +## > >> +# @SocketAddress > >> +# > >> +# Captures the address of a socket, which could also be a named file descriptor > >> +# > >> +# Since 1.3 > >> +## > >> +{ 'union': 'SocketAddress', > >> + 'data': { > >> + 'inet': 'IPSocketAddress', > > > > Call it InetSocketAddress, like 'inet', AF_INET, PF_INET, and so forth. > > Ok. Luiz, at this point please unqueue the series. I'll send a pull > request myself to Anthony. Done.