From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:45906) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TOZXb-0008U2-Cc for qemu-devel@nongnu.org; Wed, 17 Oct 2012 15:44:33 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TOZXa-00046e-CU for qemu-devel@nongnu.org; Wed, 17 Oct 2012 15:44:31 -0400 Date: Wed, 17 Oct 2012 16:45:25 -0300 From: Luiz Capitulino Message-ID: <20121017164525.0e9b2941@doriath.home> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: [Qemu-devel] [PATCH] block: bdrv_create(): don't leak cco.filename on error List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel Cc: qemu-trivial@nongnu.org, Kevin Wolf Signed-off-by: Luiz Capitulino --- block.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/block.c b/block.c index 5e8184f..63bf768 100644 --- a/block.c +++ b/block.c @@ -379,7 +379,8 @@ int bdrv_create(BlockDriver *drv, const char* filename, }; if (!drv->bdrv_create) { - return -ENOTSUP; + ret = -ENOTSUP; + goto out; } if (qemu_in_coroutine()) { @@ -394,8 +395,9 @@ int bdrv_create(BlockDriver *drv, const char* filename, } ret = cco.ret; - g_free(cco.filename); +out: + g_free(cco.filename); return ret; } -- 1.7.12.315.g682ce8b