From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:60835) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TOlJQ-0000UH-9V for qemu-devel@nongnu.org; Thu, 18 Oct 2012 04:18:46 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TOlJG-0004zH-LW for qemu-devel@nongnu.org; Thu, 18 Oct 2012 04:18:40 -0400 Date: Thu, 18 Oct 2012 19:19:40 +1100 From: David Gibson Message-ID: <20121018081940.GG23523@truffula.fritz.box> References: <1350539437-535-1-git-send-email-david@gibson.dropbear.id.au> <1350539437-535-14-git-send-email-david@gibson.dropbear.id.au> <664551E5-0164-4309-B7F1-C0D65E1AF396@suse.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <664551E5-0164-4309-B7F1-C0D65E1AF396@suse.de> Subject: Re: [Qemu-devel] [PATCH 13/15] target-pcc: Convert ppcemb_tlb_t to use fixed 64-bit RPN List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Alexander Graf Cc: "qemu-ppc@nongnu.org" , "qemu-devel@nongnu.org" On Thu, Oct 18, 2012 at 08:37:20AM +0200, Alexander Graf wrote: > > > On 18.10.2012, at 07:50, David Gibson wrote: > > > Currently the ppcemb_tlb_t struct, used on a number of embedded ppc models > > to represent a TLB entry contains a target_phys_addr_t. That works > > reasonably for now, but is troublesome for saving the state, which we'll > > want to do in future. target_phys_addr_t is a large enough type to contain > > a physical address for any supported machine - and can thus, in theory at > > least, vary depending on what machines are enabled other than the one > > we're actually using right now. This makes it unsuitable for describing > > in vmstate. > > Target_phys_addr_t is actually 64bit for all ppc targets today since > some 32 bit boards support more than 32 bit address space ;). Yes, I know. In fact since recently it's 64bit always on everything. > The change still is fine though, as it makes that bit explicit. Yes. What this is leading to is the new savevm code - there are no vmstate helpers for target_phys_addr_t and my attempt to add them met with at least semi-convincing arguments against. -- David Gibson | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_ | _way_ _around_! http://www.ozlabs.org/~dgibson