From: Luiz Capitulino <lcapitulino@redhat.com>
To: Gerd Hoffmann <kraxel@redhat.com>
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH 2/3] chardev: fix QemuOpts lifecycle
Date: Thu, 18 Oct 2012 10:30:25 -0300 [thread overview]
Message-ID: <20121018103025.54051f1f@doriath.home> (raw)
In-Reply-To: <507FCB4F.7020909@redhat.com>
On Thu, 18 Oct 2012 11:26:39 +0200
Gerd Hoffmann <kraxel@redhat.com> wrote:
> Hi,
>
> >> @@ -2864,6 +2868,7 @@ void qemu_chr_delete(CharDriverState *chr)
> >> chr->chr_close(chr);
> >> g_free(chr->filename);
> >> g_free(chr->label);
> >> + qemu_opts_del(chr->opts);
> >> g_free(chr);
> >> }
> >
> > Didn't consider this in my first review, but is chardev_init_func() fine
> > with this? Basically, if we chardev_remove a device created by it (is this
> > possible?) then the opts will be freed but it will remain inserted in its
> > QemuOptsList.
>
> Hmm? Don't see your issue here.
> qemu_opts_del will also unlink from QemuOptsList ...
Missed that fact, thanks for clarifying:
Reviewed-by: Luiz Capitulino <lcapitulino@redhat.com>
next prev parent reply other threads:[~2012-10-18 13:29 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-17 10:09 [Qemu-devel] [PATCH 0/3] chardev hotplug patch series Gerd Hoffmann
2012-10-17 10:09 ` [Qemu-devel] [PATCH 1/3] chardev: add error reporting for qemu_chr_new_from_opts Gerd Hoffmann
2012-10-17 16:22 ` Luiz Capitulino
2012-10-17 10:09 ` [Qemu-devel] [PATCH 2/3] chardev: fix QemuOpts lifecycle Gerd Hoffmann
2012-10-17 16:40 ` Luiz Capitulino
2012-10-18 9:26 ` Gerd Hoffmann
2012-10-18 13:30 ` Luiz Capitulino [this message]
2012-10-17 10:09 ` [Qemu-devel] [PATCH 3/3] chardev: add hotplug support Gerd Hoffmann
2012-10-17 15:26 ` Eric Blake
2012-10-17 16:28 ` Paolo Bonzini
2012-10-18 10:03 ` Gerd Hoffmann
2012-10-18 18:44 ` Paolo Bonzini
-- strict thread matches above, loose matches on Subject: below --
2012-12-14 9:38 [Qemu-devel] [PATCH RESENT 0/3] chardev hotplug patch series Gerd Hoffmann
2012-12-14 9:38 ` [Qemu-devel] [PATCH 2/3] chardev: fix QemuOpts lifecycle Gerd Hoffmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121018103025.54051f1f@doriath.home \
--to=lcapitulino@redhat.com \
--cc=kraxel@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).