From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:43543)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <lcapitulino@redhat.com>) id 1TOqEU-000850-VG
	for qemu-devel@nongnu.org; Thu, 18 Oct 2012 09:34:01 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <lcapitulino@redhat.com>) id 1TOqET-0001G5-Tj
	for qemu-devel@nongnu.org; Thu, 18 Oct 2012 09:33:54 -0400
Received: from mx1.redhat.com ([209.132.183.28]:8096)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <lcapitulino@redhat.com>) id 1TOqET-0001Fy-LX
	for qemu-devel@nongnu.org; Thu, 18 Oct 2012 09:33:53 -0400
Received: from int-mx12.intmail.prod.int.phx2.redhat.com
	(int-mx12.intmail.prod.int.phx2.redhat.com [10.5.11.25])
	by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q9IDXqnH029563
	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK)
	for <qemu-devel@nongnu.org>; Thu, 18 Oct 2012 09:33:53 -0400
Date: Thu, 18 Oct 2012 10:34:47 -0300
From: Luiz Capitulino <lcapitulino@redhat.com>
Message-ID: <20121018103447.5942ebe8@doriath.home>
In-Reply-To: <507FF32B.6060509@redhat.com>
References: <1350502556-4885-1-git-send-email-lcapitulino@redhat.com>
	<1350502556-4885-4-git-send-email-lcapitulino@redhat.com>
	<507FEFA3.4040000@redhat.com> <507FF32B.6060509@redhat.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH 3/8] block: bdrv_img_create(): move
 parameter list printing to qemu-img
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Kevin Wolf <kwolf@redhat.com>
Cc: pbonzini@redhat.com, qemu-devel@nongnu.org, armbru@redhat.com

On Thu, 18 Oct 2012 14:16:43 +0200
Kevin Wolf <kwolf@redhat.com> wrote:

> Am 18.10.2012 14:01, schrieb Kevin Wolf:
> > Am 17.10.2012 21:35, schrieb Luiz Capitulino:
> >> Today, bdrv_img_create() prints the parameter list used to create the
> >> new image to stdout, like this:
> >>
> >>    Formatting '/tmp/a', fmt=qcow2 size=10737418240 encryption=off cluster_size=65536 lazy_refcounts=off
> >>
> >> As the transaction QMP command calls bdrv_img_create(), this message
> >> is also printed when using QMP.
> >>
> >> This commit moves the printing of the parameter list to qemu-img instead.
> >> This way we avoid printing it in QMP and from whatever bdrv_img_create()
> >> usage we might have in the future.
> >>
> >> Signed-off-by: Luiz Capitulino <lcapitulino@redhat.com>
> > 
> > I believe the idea was that this message is printed before actually
> > creating the image, which in the case of preallocation could take a while.
> 
> The other thing is that I think you don't print the message any more
> when creating the image fails. Did you check that qemu-iotests doesn't
> need any updates?

I didn't. But I'll preserve today's behavior for v2 as I mentioned in my
last email.