From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:33237)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <lcapitulino@redhat.com>) id 1TOqT1-0005xp-TU
	for qemu-devel@nongnu.org; Thu, 18 Oct 2012 09:49:04 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <lcapitulino@redhat.com>) id 1TOqSu-0005m5-4j
	for qemu-devel@nongnu.org; Thu, 18 Oct 2012 09:48:55 -0400
Received: from mx1.redhat.com ([209.132.183.28]:33734)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <lcapitulino@redhat.com>) id 1TOqSt-0005lp-SQ
	for qemu-devel@nongnu.org; Thu, 18 Oct 2012 09:48:48 -0400
Received: from int-mx10.intmail.prod.int.phx2.redhat.com
	(int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23])
	by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q9IDmlQO009987
	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK)
	for <qemu-devel@nongnu.org>; Thu, 18 Oct 2012 09:48:47 -0400
Date: Thu, 18 Oct 2012 10:49:41 -0300
From: Luiz Capitulino <lcapitulino@redhat.com>
Message-ID: <20121018104941.486f1404@doriath.home>
In-Reply-To: <507FF1FC.1060502@redhat.com>
References: <1350502556-4885-1-git-send-email-lcapitulino@redhat.com>
	<1350502556-4885-6-git-send-email-lcapitulino@redhat.com>
	<507FF1FC.1060502@redhat.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH 5/8] qemu-img: img_create(): use Error
	object
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Kevin Wolf <kwolf@redhat.com>
Cc: pbonzini@redhat.com, qemu-devel@nongnu.org, armbru@redhat.com

On Thu, 18 Oct 2012 14:11:40 +0200
Kevin Wolf <kwolf@redhat.com> wrote:

> Am 17.10.2012 21:35, schrieb Luiz Capitulino:
> > Signed-off-by: Luiz Capitulino <lcapitulino@redhat.com>
> > ---
> >  qemu-img.c | 10 +++++++---
> >  1 file changed, 7 insertions(+), 3 deletions(-)
> > 
> > diff --git a/qemu-img.c b/qemu-img.c
> > index 12fb6c2..dfde588 100644
> > --- a/qemu-img.c
> > +++ b/qemu-img.c
> > @@ -302,6 +302,7 @@ static int img_create(int argc, char **argv)
> >      const char *base_filename = NULL;
> >      char *options = NULL;
> >      QEMUOptionParameter *params = NULL;
> > +    Error *local_err = NULL;
> >  
> >      for(;;) {
> >          c = getopt(argc, argv, "F:b:f:he6o:");
> > @@ -362,9 +363,12 @@ static int img_create(int argc, char **argv)
> >          goto out;
> >      }
> >  
> > -    ret = bdrv_img_create(filename, fmt, base_filename, base_fmt,
> > -                          options, img_size, BDRV_O_FLAGS, &params, NULL);
> > -    if (ret < 0) {
> > +    bdrv_img_create(filename, fmt, base_filename, base_fmt,
> > +                    options, img_size, BDRV_O_FLAGS, &params, &local_err);
> > +    if (error_is_set(&local_err)) {
> > +        fprintf(stderr, "qemu-img: %s\n", error_get_pretty(local_err));
> 
> This should use error_report() instead of adding the "qemu-img:" manually.

If you want to do it for consistency with the current code then ok,
I'll do it for v2. But I disagree qemu-img should keep using error_report(),
printing to hmp for example is something beyond the interests of a tool like
qemu-img.

I think we should use something like this for the tools:

static void print_error(const Error **errp)
{
    fprintf(stderr, "%s: %s\n", progname, error_get_pretty(errp));
}

Where progname is set during initialization.