From: Igor Mammedov <imammedo@redhat.com>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: Blue Swirl <blauwirbel@gmail.com>,
qemu-devel@nongnu.org, patches@linaro.org
Subject: Re: [Qemu-devel] [PATCH v2 2/8] hw/hw.h: Add include of qemu-log.h
Date: Thu, 18 Oct 2012 16:26:34 +0200 [thread overview]
Message-ID: <20121018162634.29447161@nial.usersys.redhat.com> (raw)
In-Reply-To: <1350565902-23940-3-git-send-email-peter.maydell@linaro.org>
On Thu, 18 Oct 2012 14:11:36 +0100
Peter Maydell <peter.maydell@linaro.org> wrote:
> Add an include of qemu-log.h to hw.h, so that device model
> code has access to these logging functions without the need
> to directly include qemu-log.h.
It would be better to include qemu-log.h to files that have
immediate dependency on it, then creating another include all
"qemu-common.h." and compile/preprocess it for every hw file.
>
> Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
> ---
> hw/hw.h | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/hw/hw.h b/hw/hw.h
> index 16101de..b337ee3 100644
> --- a/hw/hw.h
> +++ b/hw/hw.h
> @@ -12,6 +12,7 @@
> #include "irq.h"
> #include "qemu-file.h"
> #include "vmstate.h"
> +#include "qemu-log.h"
>
> #ifdef NEED_CPU_H
> #if TARGET_LONG_BITS == 64
next prev parent reply other threads:[~2012-10-18 14:26 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-18 13:11 [Qemu-devel] [PATCH v2 0/8] Add LOG_GUEST_ERROR for reporting guest bugs Peter Maydell
2012-10-18 13:11 ` [Qemu-devel] [PATCH v2 1/8] qemu-log: Add new log category for " Peter Maydell
2012-10-18 13:11 ` [Qemu-devel] [PATCH v2 2/8] hw/hw.h: Add include of qemu-log.h Peter Maydell
2012-10-18 14:26 ` Igor Mammedov [this message]
2012-10-18 14:30 ` Peter Maydell
2012-10-18 13:11 ` [Qemu-devel] [PATCH v2 3/8] hw/pl181: Use LOG_UNIMP and LOG_GUEST_ERROR Peter Maydell
2012-10-18 13:11 ` [Qemu-devel] [PATCH v2 4/8] hw/pl041: Use LOG_UNIMP Peter Maydell
2012-10-18 13:11 ` [Qemu-devel] [PATCH v2 5/8] hw/pl190: Use LOG_GUEST_ERROR Peter Maydell
2012-10-18 13:11 ` [Qemu-devel] [PATCH v2 6/8] hw/pl011: Use LOG_UNIMP and LOG_GUEST_ERROR Peter Maydell
2012-10-18 13:11 ` [Qemu-devel] [PATCH v2 7/8] hw/pl022: " Peter Maydell
2012-10-18 13:11 ` [Qemu-devel] [PATCH v2 8/8] hw/pl031: Use LOG_GUEST_ERROR Peter Maydell
2012-10-20 8:48 ` [Qemu-devel] [PATCH v2 0/8] Add LOG_GUEST_ERROR for reporting guest bugs Blue Swirl
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121018162634.29447161@nial.usersys.redhat.com \
--to=imammedo@redhat.com \
--cc=blauwirbel@gmail.com \
--cc=patches@linaro.org \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).