From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:33925) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TOr3e-0005DD-V7 for qemu-devel@nongnu.org; Thu, 18 Oct 2012 10:26:50 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TOr3Z-0008GW-0S for qemu-devel@nongnu.org; Thu, 18 Oct 2012 10:26:46 -0400 Received: from mx1.redhat.com ([209.132.183.28]:15464) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TOr3Y-0008GM-OU for qemu-devel@nongnu.org; Thu, 18 Oct 2012 10:26:40 -0400 Date: Thu, 18 Oct 2012 16:26:34 +0200 From: Igor Mammedov Message-ID: <20121018162634.29447161@nial.usersys.redhat.com> In-Reply-To: <1350565902-23940-3-git-send-email-peter.maydell@linaro.org> References: <1350565902-23940-1-git-send-email-peter.maydell@linaro.org> <1350565902-23940-3-git-send-email-peter.maydell@linaro.org> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v2 2/8] hw/hw.h: Add include of qemu-log.h List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Maydell Cc: Blue Swirl , qemu-devel@nongnu.org, patches@linaro.org On Thu, 18 Oct 2012 14:11:36 +0100 Peter Maydell wrote: > Add an include of qemu-log.h to hw.h, so that device model > code has access to these logging functions without the need > to directly include qemu-log.h. It would be better to include qemu-log.h to files that have immediate dependency on it, then creating another include all "qemu-common.h." and compile/preprocess it for every hw file. > > Signed-off-by: Peter Maydell > --- > hw/hw.h | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/hw/hw.h b/hw/hw.h > index 16101de..b337ee3 100644 > --- a/hw/hw.h > +++ b/hw/hw.h > @@ -12,6 +12,7 @@ > #include "irq.h" > #include "qemu-file.h" > #include "vmstate.h" > +#include "qemu-log.h" > > #ifdef NEED_CPU_H > #if TARGET_LONG_BITS == 64