From: Stefan Hajnoczi <stefanha@gmail.com>
To: Dmitry Fleytman <dmitry@daynix.com>
Cc: Yan Vugenfirer <yan@daynix.com>,
Chris Webb <chris.webb@elastichosts.com>,
qemu-devel@nongnu.org,
Richard Davies <richard.davies@elastichosts.com>
Subject: Re: [Qemu-devel] [PATCH V3] e1000: drop check_rxov, always treat RX ring with RDH == RDT as empty
Date: Fri, 19 Oct 2012 09:52:12 +0200 [thread overview]
Message-ID: <20121019075212.GC1126@stefanha-thinkpad.redhat.com> (raw)
In-Reply-To: <1350626215-24558-2-git-send-email-dmitry@daynix.com>
On Fri, Oct 19, 2012 at 07:56:55AM +0200, Dmitry Fleytman wrote:
> Real HW always treats RX ring with RDH == RDT as empty.
> Emulation is supposed to behave the same.
>
> Reported-by: Chris Webb <chris.webb@elastichosts.com>
> Reported-by: Richard Davies <richard.davies@elastichosts.com>
> Signed-off-by: Dmitry Fleytman <dmitry@daynix.com>
> ---
> hw/e1000.c | 7 ++-----
> 1 file changed, 2 insertions(+), 5 deletions(-)
Applied to the net tree:
http://github.com/stefanha/qemu/commits/net
Thanks for your efforts in squashing this bug! Glad it was possible to
drop check_rxov.
Stefan
next prev parent reply other threads:[~2012-10-19 7:52 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-19 5:56 [Qemu-devel] [PATCH V3] E1000 RX ring management fix Dmitry Fleytman
2012-10-19 5:56 ` [Qemu-devel] [PATCH V3] e1000: drop check_rxov, always treat RX ring with RDH == RDT as empty Dmitry Fleytman
2012-10-19 7:52 ` Stefan Hajnoczi [this message]
2012-10-19 8:46 ` Dmitry Fleytman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121019075212.GC1126@stefanha-thinkpad.redhat.com \
--to=stefanha@gmail.com \
--cc=chris.webb@elastichosts.com \
--cc=dmitry@daynix.com \
--cc=qemu-devel@nongnu.org \
--cc=richard.davies@elastichosts.com \
--cc=yan@daynix.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).