From: Aurelien Jarno <aurelien@aurel32.net>
To: Jan Kiszka <jan.kiszka@siemens.com>
Cc: Anthony Liguori <aliguori@us.ibm.com>,
Corey Bryant <coreyb@linux.vnet.ibm.com>,
Michael Tokarev <mjt@tls.msk.ru>,
qemu-devel <qemu-devel@nongnu.org>,
qemu-stable <qemu-stable@nongnu.org>
Subject: Re: [Qemu-devel] [PATCH] configure: Fix CONFIG_QEMU_HELPERDIR generation
Date: Fri, 19 Oct 2012 21:33:15 +0200 [thread overview]
Message-ID: <20121019193315.GG22247@ohm.aurel32.net> (raw)
In-Reply-To: <507EE645.7040403@siemens.com>
On Wed, Oct 17, 2012 at 07:09:25PM +0200, Jan Kiszka wrote:
> We need to evaluate $libexecdir in configure, otherwise we literally end
> up with "${prefix}/libexec" instead of the absolute path as
> CONFIG_QEMU_HELPERDIR.
>
> Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
> ---
> configure | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/configure b/configure
> index 353d788..e3a1780 100755
> --- a/configure
> +++ b/configure
> @@ -3227,7 +3227,7 @@ echo "qemu_confdir=$qemu_confdir" >> $config_host_mak
> echo "qemu_datadir=$qemu_datadir" >> $config_host_mak
> echo "qemu_docdir=$qemu_docdir" >> $config_host_mak
> echo "qemu_localstatedir=$local_statedir" >> $config_host_mak
> -echo "CONFIG_QEMU_HELPERDIR=\"$libexecdir\"" >> $config_host_mak
> +echo "CONFIG_QEMU_HELPERDIR=\"`eval echo $libexecdir`\"" >> $config_host_mak
>
> echo "ARCH=$ARCH" >> $config_host_mak
> if test "$debug_tcg" = "yes" ; then
Thanks, applied.
--
Aurelien Jarno GPG: 1024D/F1BCDB73
aurelien@aurel32.net http://www.aurel32.net
next prev parent reply other threads:[~2012-10-19 19:33 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-17 17:09 [Qemu-devel] [PATCH] configure: Fix CONFIG_QEMU_HELPERDIR generation Jan Kiszka
2012-10-19 19:33 ` Aurelien Jarno [this message]
2012-10-21 18:58 ` Michael Tokarev
2012-10-22 6:12 ` Aurelien Jarno
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121019193315.GG22247@ohm.aurel32.net \
--to=aurelien@aurel32.net \
--cc=aliguori@us.ibm.com \
--cc=coreyb@linux.vnet.ibm.com \
--cc=jan.kiszka@siemens.com \
--cc=mjt@tls.msk.ru \
--cc=qemu-devel@nongnu.org \
--cc=qemu-stable@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).