From: Stefan Hajnoczi <stefanha@gmail.com>
To: Dong Xu Wang <wdongxu@linux.vnet.ibm.com>
Cc: kwolf@redhat.com, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH V13 4/6] rename qcow2-cache.c to block-cache.c
Date: Mon, 22 Oct 2012 10:22:12 +0200 [thread overview]
Message-ID: <20121022082212.GB31790@stefanha-thinkpad.redhat.com> (raw)
In-Reply-To: <1350553895-3388-5-git-send-email-wdongxu@linux.vnet.ibm.com>
On Thu, Oct 18, 2012 at 05:51:33PM +0800, Dong Xu Wang wrote:
> diff --git a/block/qcow2.h b/block/qcow2.h
> index b4eb654..cb6fd7a 100644
> --- a/block/qcow2.h
> +++ b/block/qcow2.h
> @@ -27,6 +27,7 @@
>
> #include "aes.h"
> #include "qemu-coroutine.h"
> +#include "block-cache.h"
>
Since block-cache.h is being included from qcow2.h you can drop the
block-cache.h includes you added to qcow2-cluster.c and
qcow2-refcount.c.
Stefan
next prev parent reply other threads:[~2012-10-22 8:22 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-18 9:51 [Qemu-devel] [PATCH V13 0/6] add-cow file format Dong Xu Wang
2012-10-18 9:51 ` [Qemu-devel] [PATCH V13 1/6] docs: document for " Dong Xu Wang
2012-10-18 16:10 ` Eric Blake
2012-10-19 2:14 ` Dong Xu Wang
2012-10-18 9:51 ` [Qemu-devel] [PATCH V13 2/6] make path_has_protocol non static Dong Xu Wang
2012-10-18 9:51 ` [Qemu-devel] [PATCH V13 3/6] qed_read_string to bdrv_read_string Dong Xu Wang
2012-10-18 9:51 ` [Qemu-devel] [PATCH V13 4/6] rename qcow2-cache.c to block-cache.c Dong Xu Wang
2012-10-22 8:22 ` Stefan Hajnoczi [this message]
2012-10-22 8:24 ` Dong Xu Wang
2012-10-18 9:51 ` [Qemu-devel] [PATCH V13 5/6] add-cow file format core code Dong Xu Wang
2012-10-22 9:29 ` Stefan Hajnoczi
2012-10-18 9:51 ` [Qemu-devel] [PATCH V13 6/6] qemu-iotests: add add-cow iotests support Dong Xu Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121022082212.GB31790@stefanha-thinkpad.redhat.com \
--to=stefanha@gmail.com \
--cc=kwolf@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=wdongxu@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).