From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:56742) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TQK4j-0003M3-VG for qemu-devel@nongnu.org; Mon, 22 Oct 2012 11:37:58 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TQK4i-0005Ct-Ut for qemu-devel@nongnu.org; Mon, 22 Oct 2012 11:37:57 -0400 Received: from mx1.redhat.com ([209.132.183.28]:31152) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TQK4i-0005Cn-MH for qemu-devel@nongnu.org; Mon, 22 Oct 2012 11:37:56 -0400 Received: from int-mx01.intmail.prod.int.phx2.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q9MFbtdc000722 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Mon, 22 Oct 2012 11:37:56 -0400 Date: Mon, 22 Oct 2012 13:38:52 -0200 From: Luiz Capitulino Message-ID: <20121022133852.3e48d747@doriath.home> In-Reply-To: <508567DE.1010304@redhat.com> References: <1350657924-10624-1-git-send-email-pbonzini@redhat.com> <1350657924-10624-2-git-send-email-pbonzini@redhat.com> <20121022130637.723ccc6a@doriath.home> <508567DE.1010304@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v2 1/2] qmp: handle stop/cont in INMIGRATE state List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini Cc: qemu-devel@nongnu.org On Mon, 22 Oct 2012 17:35:58 +0200 Paolo Bonzini wrote: > Il 22/10/2012 17:06, Luiz Capitulino ha scritto: > >> > Note that libvirt is currently working around the race by looping > >> > if the MigrationExpected answer is returned. After this patch, the > >> > command will return right away without ever raising an error. > >> > > >> > Signed-off-by: Paolo Bonzini > > Could you please add a note in cont's and stop's entries in qapi-schema.json > > explaining their behavior on INMIGRATE? > > > > Otherwise series looks good. > > > > Can I do that as a followup? You can re-work 1/2 and submit only that one. I'll order the two patches correctly in my queue.