From: Luiz Capitulino <lcapitulino@redhat.com>
To: Corey Bryant <coreyb@linux.vnet.ibm.com>
Cc: kwolf@redhat.com, gollub@b1-systems.de, qemu-devel@nongnu.org,
agraf@suse.de
Subject: Re: [Qemu-devel] [PATCH] main: Hide F_GETFD and FD_CLOEXEC use for _WIN32
Date: Mon, 22 Oct 2012 14:16:17 -0200 [thread overview]
Message-ID: <20121022141617.754fce0e@doriath.home> (raw)
In-Reply-To: <1350914024-4794-1-git-send-email-coreyb@linux.vnet.ibm.com>
On Mon, 22 Oct 2012 09:53:44 -0400
Corey Bryant <coreyb@linux.vnet.ibm.com> wrote:
>
> Signed-off-by: Corey Bryant <coreyb@linux.vnet.ibm.com>
> ---
> vl.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/vl.c b/vl.c
> index 200d849..94c667d 100644
> --- a/vl.c
> +++ b/vl.c
> @@ -812,11 +812,13 @@ static int parse_add_fd(QemuOpts *opts, void *opaque)
> return -1;
> }
>
> +#ifndef _WIN32
> if (fcntl(fd, F_GETFD) & FD_CLOEXEC) {
> qerror_report(ERROR_CLASS_GENERIC_ERROR,
> "fd is not valid or already in use");
> return -1;
> }
> +#endif
Which series is this from? The command-line support for fd sets?
qerror_report() is deprecated.
>
> if (fdset_id < 0) {
> qerror_report(ERROR_CLASS_GENERIC_ERROR,
next prev parent reply other threads:[~2012-10-22 16:15 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-22 13:53 [Qemu-devel] [PATCH] main: Hide F_GETFD and FD_CLOEXEC use for _WIN32 Corey Bryant
2012-10-22 16:16 ` Luiz Capitulino [this message]
2012-10-22 17:46 ` Corey Bryant
2012-10-23 9:47 ` Kevin Wolf
2012-10-22 16:28 ` Stefan Weil
2012-10-22 17:35 ` Corey Bryant
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121022141617.754fce0e@doriath.home \
--to=lcapitulino@redhat.com \
--cc=agraf@suse.de \
--cc=coreyb@linux.vnet.ibm.com \
--cc=gollub@b1-systems.de \
--cc=kwolf@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).