From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:60763) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TQKfM-0006Qs-8B for qemu-devel@nongnu.org; Mon, 22 Oct 2012 12:15:53 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TQKfE-0000ok-TR for qemu-devel@nongnu.org; Mon, 22 Oct 2012 12:15:48 -0400 Received: from mx1.redhat.com ([209.132.183.28]:36499) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TQKfE-0000nb-Kl for qemu-devel@nongnu.org; Mon, 22 Oct 2012 12:15:40 -0400 Date: Mon, 22 Oct 2012 14:16:17 -0200 From: Luiz Capitulino Message-ID: <20121022141617.754fce0e@doriath.home> In-Reply-To: <1350914024-4794-1-git-send-email-coreyb@linux.vnet.ibm.com> References: <1350914024-4794-1-git-send-email-coreyb@linux.vnet.ibm.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] main: Hide F_GETFD and FD_CLOEXEC use for _WIN32 List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Corey Bryant Cc: kwolf@redhat.com, gollub@b1-systems.de, qemu-devel@nongnu.org, agraf@suse.de On Mon, 22 Oct 2012 09:53:44 -0400 Corey Bryant wrote: > > Signed-off-by: Corey Bryant > --- > vl.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/vl.c b/vl.c > index 200d849..94c667d 100644 > --- a/vl.c > +++ b/vl.c > @@ -812,11 +812,13 @@ static int parse_add_fd(QemuOpts *opts, void *opaque) > return -1; > } > > +#ifndef _WIN32 > if (fcntl(fd, F_GETFD) & FD_CLOEXEC) { > qerror_report(ERROR_CLASS_GENERIC_ERROR, > "fd is not valid or already in use"); > return -1; > } > +#endif Which series is this from? The command-line support for fd sets? qerror_report() is deprecated. > > if (fdset_id < 0) { > qerror_report(ERROR_CLASS_GENERIC_ERROR,