From: Aurelien Jarno <aurelien@aurel32.net>
To: Richard Henderson <rth@twiddle.net>
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH 1/3] tcg-alpha: Fix type mismatch errors in cpu_signal_handler.
Date: Mon, 22 Oct 2012 23:39:26 +0200 [thread overview]
Message-ID: <20121022213926.GA8486@ohm.aurel32.net> (raw)
In-Reply-To: <1348942239-3081-2-git-send-email-rth@twiddle.net>
On Sat, Sep 29, 2012 at 11:10:37AM -0700, Richard Henderson wrote:
> Signed-off-by: Richard Henderson <rth@twiddle.net>
> ---
> user-exec.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/user-exec.c b/user-exec.c
> index ef9b172..1635e4a 100644
> --- a/user-exec.c
> +++ b/user-exec.c
> @@ -352,8 +352,8 @@ int cpu_signal_handler(int host_signum, void *pinfo,
> {
> siginfo_t *info = pinfo;
> struct ucontext *uc = puc;
> - uint32_t *pc = uc->uc_mcontext.sc_pc;
> - uint32_t insn = *pc;
> + unsigned long pc = uc->uc_mcontext.sc_pc;
> + uint32_t insn = *(uint32_t *)pc;
> int is_write = 0;
>
> /* XXX: need kernel patch to get write flag faster */
Reviewed-by: Aurelien Jarno <aurelien@aurel32.net>
--
Aurelien Jarno GPG: 1024D/F1BCDB73
aurelien@aurel32.net http://www.aurel32.net
next prev parent reply other threads:[~2012-10-22 21:39 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-29 18:10 [Qemu-devel] [PATCH 0/3] Alpha TCG host Richard Henderson
2012-09-29 18:10 ` [Qemu-devel] [PATCH 1/3] tcg-alpha: Fix type mismatch errors in cpu_signal_handler Richard Henderson
2012-09-29 18:26 ` Stefan Weil
2012-10-22 21:39 ` Aurelien Jarno [this message]
2012-09-29 18:10 ` [Qemu-devel] [PATCH 2/3] tcg-alpha: Don't use a custom linker script Richard Henderson
2012-10-22 21:39 ` Aurelien Jarno
2012-09-29 18:10 ` [Qemu-devel] [PATCH 3/3] tcg-alpha: New TCG target Richard Henderson
2012-10-22 21:39 ` Aurelien Jarno
2012-10-22 23:14 ` Richard Henderson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121022213926.GA8486@ohm.aurel32.net \
--to=aurelien@aurel32.net \
--cc=qemu-devel@nongnu.org \
--cc=rth@twiddle.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).