From: Luiz Capitulino <lcapitulino@redhat.com>
To: Lei Li <lilei@linux.vnet.ibm.com>
Cc: blauwirbel@gmail.com, aliguori@us.ibm.com, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH 1/5] qemu-char: Add new char backend CircularMemCharDriver
Date: Tue, 23 Oct 2012 10:42:23 -0200 [thread overview]
Message-ID: <20121023104223.41ad0081@doriath.home> (raw)
In-Reply-To: <50862DBD.4010403@linux.vnet.ibm.com>
On Tue, 23 Oct 2012 13:40:13 +0800
Lei Li <lilei@linux.vnet.ibm.com> wrote:
> >> +static int cirmem_chr_write(CharDriverState *chr, const uint8_t *buf, int len)
> >> +{
> >> + CirMemCharDriver *d = chr->opaque;
> >> + int i;
> >> +
> >> + if (len < 0) {
> >> + return -1;
> >> + }
> >> +
> >> + /* The size should be a power of 2. */
> > Shouldn't you enforce that, then?
>
> Yes, it has been checked when open the CirMemChar backend in patch 2/5,
> as code below:
>
> if (d->size & (d->size -1)) {
> return NULL;
> }
You could add an assert() in cirmem_chr_write() then.
next prev parent reply other threads:[~2012-10-23 12:42 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-21 16:47 [Qemu-devel] [PATCH 0/5 V4] char: add CirMemCharDriver and provide QMP interface Lei Li
2012-10-21 16:47 ` [Qemu-devel] [PATCH 1/5] qemu-char: Add new char backend CircularMemCharDriver Lei Li
2012-10-22 14:08 ` Eric Blake
2012-10-23 5:40 ` Lei Li
2012-10-23 12:42 ` Luiz Capitulino [this message]
2012-10-22 18:14 ` Luiz Capitulino
2012-10-23 6:36 ` Lei Li
2012-10-21 16:47 ` [Qemu-devel] [PATCH 2/5] Expose CirMemCharDriver via command line Lei Li
2012-10-22 16:31 ` Luiz Capitulino
2012-10-21 16:47 ` [Qemu-devel] [PATCH 3/5] QAPI: Introduce memchar-write QMP command Lei Li
2012-10-22 18:37 ` Luiz Capitulino
2012-10-23 6:36 ` Lei Li
2012-10-23 12:44 ` Luiz Capitulino
2012-10-21 16:48 ` [Qemu-devel] [PATCH 4/5] QAPI: Introduce memchar-read " Lei Li
2012-10-22 18:43 ` Luiz Capitulino
2012-10-21 16:48 ` [Qemu-devel] [PATCH 5/5] HMP: Introduce console command Lei Li
2012-10-22 18:59 ` Luiz Capitulino
2012-10-24 7:17 ` Lei Li
2012-10-24 12:55 ` Luiz Capitulino
2012-10-25 19:43 ` Lei Li
2012-10-26 13:56 ` Luiz Capitulino
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121023104223.41ad0081@doriath.home \
--to=lcapitulino@redhat.com \
--cc=aliguori@us.ibm.com \
--cc=blauwirbel@gmail.com \
--cc=lilei@linux.vnet.ibm.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).