From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:49080) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TQdtV-0007Oa-T1 for qemu-devel@nongnu.org; Tue, 23 Oct 2012 08:47:42 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TQdtN-0006Kz-4B for qemu-devel@nongnu.org; Tue, 23 Oct 2012 08:47:41 -0400 Received: from mx1.redhat.com ([209.132.183.28]:46572) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TQdtM-0006Kh-S0 for qemu-devel@nongnu.org; Tue, 23 Oct 2012 08:47:33 -0400 Date: Tue, 23 Oct 2012 14:47:22 +0200 From: Igor Mammedov Message-ID: <20121023144722.2e910f90@thinkpad.mammed.net> In-Reply-To: <50867784.2030008@suse.de> References: <1350918203-25198-1-git-send-email-imammedo@redhat.com> <1350918203-25198-17-git-send-email-imammedo@redhat.com> <5085D4AA.1060208@CloudSwitch.Com> <20121023124032.3975a874@thinkpad.mammed.net> <50867784.2030008@suse.de> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH 16/37] target-i386: set kvm CPUID default feature values using static properties List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Andreas =?UTF-8?B?RsOkcmJlcg==?= Cc: aliguori@us.ibm.com, ehabkost@redhat.com, jan.kiszka@siemens.com, Don Slutz , qemu-devel@nongnu.org, mdroth@linux.vnet.ibm.com, blauwirbel@gmail.com, stefanha@redhat.com, pbonzini@redhat.com On Tue, 23 Oct 2012 12:55:00 +0200 Andreas F=C3=A4rber wrote: > Am 23.10.2012 12:40, schrieb Igor Mammedov: > > On Mon, 22 Oct 2012 19:20:10 -0400 > > Don Slutz wrote: > >=20 > >> On 10/22/12 11:03, Igor Mammedov wrote: > >>> Replace setting default supported kvm features in cpu_x86_find_by_nam= e() > >>> by default values in corresponding static properties. > >>> > >>> - Compile in kvm CPUID features only if CONFIG_KVM is defined. > >>> - Make "f-kvm_steal_tm" and "f-kvmclock_stable" CPUID features visibl= e as properties. > >> Not sure that KVM_FEATURE_STEAL_TIME should translate to kvm_steal_tm.= =20 > >> I think that I have seen that new names should use "-". So I would=20 > >> think the new name should be "f-kvm-steal-time". And=20 > >> KVM_FEATURE_CLOCKSOURCE_STABLE_BIT should be "f-kvm-clock-stable". > > That would be inconsistent with current naming scheme, I may be it shou= ld be > > f-kvm_steal_time and f-kvm_clock_stable for this series and than later = all > > the features converted in a single batch, its a bit out of scope of this > > patch. Alternatively a separate patch could be send to convert current > > feature name arrays to '-' scheme. I'll happily rebase series on top of= it. >=20 > I am pretty sure that someone (not me) proposed to have all new > properties with dash and to translate the command line options from _ to = -. I remember it too except of how it ended. Any way since these are new features, I do not have any preference. Naming suggested by Don are now in = WIP queue: https://github.com/imammedo/qemu/commit/fd4fc7b5abb37373d02e3f1861856846ce2= 31316 Thanks, Igor =20 >=20 > Andreas >=20 > --=20 > SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=C3=BCrnberg, Germany > GF: Jeff Hawn, Jennifer Guild, Felix Imend=C3=B6rffer; HRB 16746 AG N=C3= =BCrnberg >=20