From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:53261) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TQhXZ-0002BN-2v for qemu-devel@nongnu.org; Tue, 23 Oct 2012 12:41:22 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TQhXT-0004qq-Nu for qemu-devel@nongnu.org; Tue, 23 Oct 2012 12:41:16 -0400 Received: from verein.lst.de ([213.95.11.211]:51246 helo=newverein.lst.de) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TQhXT-0004pS-IQ for qemu-devel@nongnu.org; Tue, 23 Oct 2012 12:41:11 -0400 Date: Tue, 23 Oct 2012 18:41:09 +0200 From: Christoph Hellwig Message-ID: <20121023164109.GA15865@lst.de> References: <507C50E9.1050706@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <507C50E9.1050706@redhat.com> Subject: Re: [Qemu-devel] [PATCH] qemu-img rebase: allow backing file to be specified as '-' List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Eric Blake Cc: qemu-devel@nongnu.org, Alex Bligh On Mon, Oct 15, 2012 at 12:07:37PM -0600, Eric Blake wrote: > On 10/15/2012 11:29 AM, Alex Bligh wrote: > > This patch allows qemu-img rebase to rebase an image to > > have no backing file, as opposed to merely allowing it to > > rebase to an existing backing file. > > You can already do that by rebasing to the empty string. And it is > feasible (although unlikely) to have a file named '-', where your patch > would make it impossible to use that file directly (although you could > still use './-'). NACK. Also - is often used to tell tools that expect a file argument to use stdin/out. Something that would be quite useful for some qemu-img subcommands.