From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:36385) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TQnCw-0006Wp-U1 for qemu-devel@nongnu.org; Tue, 23 Oct 2012 18:44:24 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TQnCv-0003ql-Bn for qemu-devel@nongnu.org; Tue, 23 Oct 2012 18:44:22 -0400 Received: from e23smtp06.au.ibm.com ([202.81.31.148]:42589) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TQnCu-0003q5-R5 for qemu-devel@nongnu.org; Tue, 23 Oct 2012 18:44:21 -0400 Received: from /spool/local by e23smtp06.au.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Wed, 24 Oct 2012 08:42:08 +1000 Date: Wed, 24 Oct 2012 09:43:51 +1100 From: David Gibson Message-ID: <20121023224351.GE13231@truffula.fritz.box> References: <1350986975-21786-1-git-send-email-aviksil@linux.vnet.ibm.com> <1350986975-21786-2-git-send-email-aviksil@linux.vnet.ibm.com> <1A23CBFB-5BF8-45A3-A7FB-9E00E6D18AA1@suse.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1A23CBFB-5BF8-45A3-A7FB-9E00E6D18AA1@suse.de> Subject: Re: [Qemu-devel] [Qemu-ppc] [PATCH 1/2] Make default boot order machine specific List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Alexander Graf Cc: aliguori@us.ibm.com, qemu-ppc@nongnu.org, Avik Sil , qemu-devel@nongnu.org On Tue, Oct 23, 2012 at 12:20:08PM +0200, Alexander Graf wrote: > > On 23.10.2012, at 12:09, Avik Sil wrote: > > > This patch makes default boot order machine specific instead of > > set globally. The default boot order can be set per machine in > > QEMUMachine default_machine_opts, or by the command line using > > -machine ,boot=, or by standard -boot > > option. This allows a machine to receive a NULL boot order when > > -boot isn't used and take an appropriate action accordingly. This > > helps machine boots from the devices as set in guest's non-volatile > > memory location in case no boot order is provided by the user. > > > > Signed-off-by: Avik Sil > > --- > > hw/nseries.c | 2 ++ > > hw/pc_piix.c | 13 ++++++++++++- > > hw/ppc_newworld.c | 1 + > > hw/ppc_oldworld.c | 1 + > > hw/ppc_prep.c | 1 + > > hw/sun4m.c | 10 ++++++++++ > > hw/sun4u.c | 3 +++ > > That feels like too much magic for my taste. Can't we have some > default macro (or even the explicit "cad" thing) that we push to > _every_ machine description out there? The next patch to implement > boot= for pseries would then remove this default value for the > pseries machine. I'm not 100% clear on what you mean here. Do you just mean: #define DEFAULT_BOOT_ORDER "boot=cad" and then we use .default_machine_opts = DEFAULT_BOOT_ORDER, or something else? > The way the patch works right now, the "make machine specific" patch > indirectly also changes the behavior for a bunch of machines. A bunch? I thought the only machine whose behaviour changed was pseries. I agree that moving the behaviour change into a separate patch would be a better idea, but if there are machines other than pseries with changed behaviour by this patch, then that's a plain old bug, rather than a mere question of patch elegance. -- David Gibson | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_ | _way_ _around_! http://www.ozlabs.org/~dgibson